From the list of baskets with a specific vendor, there is an action button which will allow users to close the basket. Clicking on this option will not close the basket and brings the user to a page koha/acqui/basket.pl?op=close&basketno=84&booksellerid=6 And the page will display this: New Basket () for There are still Basket options on this page, but choosing to close the basket, will give the message, Vendor Not Found. Choosing to edit the basket from this page, will give a 500 error.
Created attachment 169510 [details] [review] Bug 37450: Fix 'Close basket' button from list of baskets To test: 1) In acquisitions, have a vendor with an item (or items) in their basket. Search for this vendor. 2) From the actions column, select the arrow and then press 'Close this basket' 3) Clicking on this option will not close the basket and brings us to the wrong page 4) Apply patch 5) Try to close the basket again, and this time, it is closed successfully
Sam - should the status be 'needs sign-off'?
Created attachment 169565 [details] [review] Bug 37450: Fix 'Close basket' button from list of baskets To test: 1) In acquisitions, have a vendor with an item (or items) in their basket. Search for this vendor. 2) From the actions column, select the arrow and then press 'Close this basket' 3) Clicking on this option will not close the basket and brings us to the wrong page 4) Apply patch 5) Try to close the basket again, and this time, it is closed successfully Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Created attachment 170100 [details] [review] Bug 37450: Fix 'Close basket' button from list of baskets QA tool is happy and the patch works great. Passing QA!
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.04
"cud-" not in 23.11.x