37578 – Remove the Charges tab from checkout and patron details

Bug 37578 - Remove the Charges tab from checkout and patron details

Summary: Remove the Charges tab from checkout and patron details

Status:	RESOLVED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Templates (show other bugs)
Version:	Main
Hardware:	All All

Importance:	P5 - low enhancement
Assignee:	Owen Leonard
QA Contact:	Testopia

URL:
Keywords:

Depends on:
Blocks:

Reported:	2024-08-06 13:04 UTC by Owen Leonard
Modified:	2024-11-08 15:18 UTC (History)
CC List:	3 users (show)

See Also:
Change sponsored?:	---
Patch complexity:	Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:	This patch removes the unused 'Charges' tab from the include file for patron accounts in the circulation and patron details templates. Information about charges and credits is already shown as a warning message at the top of these pages as well as in the left side menu in the 'Accounting' tab.
Version(s) released in:	24.11.00
Circulation function:

Attachments
Bug 37578: Remove the Charges tab from checkout and patron details (1.88 KB, patch) 2024-08-06 17:08 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 37578: Remove the Charges tab from checkout and patron details (2.41 KB, patch) 2024-08-06 17:10 UTC, Owen Leonard	Details \| Diff \| Splinter Review
Bug 37578: Remove the Charges tab from checkout and patron details (2.47 KB, patch) 2024-08-09 12:16 UTC, Biblibre Sandboxes	Details \| Diff \| Splinter Review
Bug 37578: Remove the Charges tab from checkout and patron details (2.53 KB, patch) 2024-08-09 13:45 UTC, Tomás Cohen Arazi (tcohen)	Details \| Diff \| Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Owen Leonard 2024-08-06 13:04:24 UTC

Showing a "Charges" tab next to checkouts, holds, etc. on the patron checkout and detail pages is redundant: Information about charges and credits is already shown at the top of those pages under the "Attention" heading.

I think we can remove the tab without compromising users' ability to find the information.

Comment 1 Owen Leonard 2024-08-06 17:08:00 UTC Comment hidden (obsolete)

Created attachment 170103 [details] [review]
Bug 37578: Remove the Charges tab from checkout and patron details

This patch removes the "Charges" tab from the include file which is used
by the circulation and patron details templates. Information about
charges and credits is already shown at the top of these pages under the
"Attention" heading.

This tab is already hidden on the checkout page
because the script doesn't provide the data to display.

To test, apply the patch locate a patron with charges.

- Check out to the patron. As before, you should see under the
  "Attention" heading at the top, "Charges: Patron has outstanding
  charges of..."
- There should be no "Charges" tab below in the section showing tabs for
  checkouts, holds, etc.
- Check the same details on the patron detai page.
- A patron with credits should be displayed similarly.

Sponsored-by: Athens County Public Libraries

Comment 2 Owen Leonard 2024-08-06 17:10:33 UTC

Created attachment 170104 [details] [review]
Bug 37578: Remove the Charges tab from checkout and patron details

This patch removes the "Charges" tab from the include file which is used
by the circulation and patron details templates. Information about
charges and credits is already shown at the top of these pages under the
"Attention" heading.

This tab is already hidden on the checkout page
because the script doesn't provide the data to display.

To test, apply the patch locate a patron with charges.

- Check out to the patron. As before, you should see under the
  "Attention" heading at the top, "Charges: Patron has outstanding
  charges of..."
- There should be no "Charges" tab below in the section showing tabs for
  checkouts, holds, etc.
- Check the same details on the patron detai page.
- A patron with credits should be displayed similarly.

Sponsored-by: Athens County Public Libraries

Comment 3 Biblibre Sandboxes 2024-08-09 12:16:34 UTC

Created attachment 170183 [details] [review]
Bug 37578: Remove the Charges tab from checkout and patron details

This patch removes the "Charges" tab from the include file which is used
by the circulation and patron details templates. Information about
charges and credits is already shown at the top of these pages under the
"Attention" heading.

This tab is already hidden on the checkout page
because the script doesn't provide the data to display.

To test, apply the patch locate a patron with charges.

- Check out to the patron. As before, you should see under the
  "Attention" heading at the top, "Charges: Patron has outstanding
  charges of..."
- There should be no "Charges" tab below in the section showing tabs for
  checkouts, holds, etc.
- Check the same details on the patron detai page.
- A patron with credits should be displayed similarly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de>

Comment 4 Tomás Cohen Arazi (tcohen) 2024-08-09 13:45:42 UTC

Created attachment 170193 [details] [review]
Bug 37578: Remove the Charges tab from checkout and patron details

This patch removes the "Charges" tab from the include file which is used
by the circulation and patron details templates. Information about
charges and credits is already shown at the top of these pages under the
"Attention" heading.

This tab is already hidden on the checkout page
because the script doesn't provide the data to display.

To test, apply the patch locate a patron with charges.

- Check out to the patron. As before, you should see under the
  "Attention" heading at the top, "Charges: Patron has outstanding
  charges of..."
- There should be no "Charges" tab below in the section showing tabs for
  checkouts, holds, etc.
- Check the same details on the patron detai page.
- A patron with credits should be displayed similarly.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Comment 5 Katrin Fischer 2024-08-09 16:49:18 UTC

Pushed for 24.11!

Well done everyone, thank you!

Comment 6 Lucas Gass (lukeg) 2024-09-11 16:23:28 UTC

Enhancement will not be backported to 24.05.x

Comment 7 Philip Orr 2024-11-08 15:18:40 UTC

added release notes