---- Reported by nengard@gmail.com 2009-11-04 20:23:00 ---- When adding/editing a patron, the authorized values for road types and cities/towns only appear next to the first address - if we really want them to be used as authorized values all addresses should have the pull downs. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:14 UTC --- This bug was previously known as _bug_ 3766 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3766 Actual time not defined. Setting to 0.0
Created attachment 25449 [details] [review] Bug 3766 - Cities/Towns and Road Types only on one address When adding a new patron only the primary contact city/state fields are linked to a dropdown listing values from stored city/state/zip/country values. The same dropdown of predefined values should be linked to alternate address and alternate contact. This patch does so by adapting the same JS and markup for these additional cases. To test you should have cities defined in Administration -> Cities. - Edit or create a new patron. - Under main address -> city select one of the predefined entries. - The city, state, zip, and country values should be correctly populated. - Test under alternate address -> city and alternate contact -> city. - Save your changes and confirm that everything worked correctly.
Created attachment 25516 [details] [review] [Signed-off] Bug 3766 - Cities/Towns and Road Types only on one address When adding a new patron only the primary contact city/state fields are linked to a dropdown listing values from stored city/state/zip/country values. The same dropdown of predefined values should be linked to alternate address and alternate contact. This patch does so by adapting the same JS and markup for these additional cases. To test you should have cities defined in Administration -> Cities. - Edit or create a new patron. - Under main address -> city select one of the predefined entries. - The city, state, zip, and country values should be correctly populated. - Test under alternate address -> city and alternate contact -> city. - Save your changes and confirm that everything worked correctly. Works as expected Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 25568 [details] [review] [PASSED QA] Bug 3766 - Cities/Towns and Road Types only on one address When adding a new patron only the primary contact city/state fields are linked to a dropdown listing values from stored city/state/zip/country values. The same dropdown of predefined values should be linked to alternate address and alternate contact. This patch does so by adapting the same JS and markup for these additional cases. To test you should have cities defined in Administration -> Cities. - Edit or create a new patron. - Under main address -> city select one of the predefined entries. - The city, state, zip, and country values should be correctly populated. - Test under alternate address -> city and alternate contact -> city. - Save your changes and confirm that everything worked correctly. Works as expected Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> This works nicely, passes all tests and QA script.
As I suspected when I read the patch, it needs a Perl change as well: [1] Edit a patron and set the main address' city using the dropdown. [2] Save the patron, then edit it again. [3] Note that the city selector on all three addresses has the main address' city as the selected entry in the dropdwon. Each addresses' city needs to be checked separately. Alternatively, the city dropdown could be redefined so that it is used only to /change/ the city, meaning that it wouldn't get a value selected by default. Marking Failed QA.
Amazingly this is still valid.
Created attachment 87530 [details] [review] Bug 3766: Cities/Towns and Road Types only on one address This patch ties the alternate address and alternate contact address fields in the patron entry form to the cities and towns data. This provides a dropdown of predefined city data to these address fields. To test, apply the patch and edit a patron record. Test city selection for all three address fields: Main address, alternate address, and alternate contact. Confirm that city selection works correctly and that your changes are saved correctly. Perform these tests with all AddressFormat options: French, German, and US.
Created attachment 87532 [details] [review] Bug 3766: Cities/Towns and Road Types only on one address This patch ties the alternate address and alternate contact address fields in the patron entry form to the cities and towns data. This provides a dropdown of predefined city data to these address fields. To test, apply the patch and edit a patron record. Test city selection for all three address fields: Main address, alternate address, and alternate contact. Confirm that city selection works correctly and that your changes are saved correctly. Perform these tests with all AddressFormat options: French, German, and US. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Hi Owen, I noticed that the third address (Alternate contact) is still missing the Road type pull down with this patch. If you prefer we could change the bug description and deal only with the cities/towns here and the road type separately? Or a quick QA follow-up?
I have created new bug 22673 for the road types, to clear the way for this bug addressing the street types, since it is fine and works well. Will tidy up the commit message here in a minute.
Created attachment 87656 [details] [review] Bug 3766: Cities/Towns only on one address This patch ties the alternate address and alternate contact address fields in the patron entry form to the cities and towns data. This provides a dropdown of predefined city data to these address fields. To test, apply the patch and edit a patron record. Test city selection for all three address fields: Main address, alternate address, and alternate contact. Confirm that city selection works correctly and that your changes are saved correctly. Perform these tests with all AddressFormat options: French, German, and US. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Created attachment 87671 [details] [review] Bug 3766: Cities/Towns only on one address This patch ties the alternate address and alternate contact address fields in the patron entry form to the cities and towns data. This provides a dropdown of predefined city data to these address fields. To test, apply the patch and edit a patron record. Test city selection for all three address fields: Main address, alternate address, and alternate contact. Confirm that city selection works correctly and that your changes are saved correctly. Perform these tests with all AddressFormat options: French, German, and US. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Awesome work all! Pushed to master for 19.05
Enhancement will not be backported to 18.11.x series.