Bug 37691 - Password expiration reset not clear enough
Summary: Password expiration reset not clear enough
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-20 17:26 UTC by Chanel Wheeler
Modified: 2024-12-09 20:39 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement alters the style of the error message shown to a staff member who tries to log in to the staff interface with an expired password. This change makes the message more visible and rewords the link text to read "Reset your password."
Version(s) released in:
24.11.00
Circulation function:


Attachments
password expiration screen (16.66 KB, image/png)
2024-08-20 17:26 UTC, Chanel Wheeler
Details
Bug 37691: Improve visibility of password expiration reset link (3.96 KB, patch)
2024-08-21 11:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37691: Improve visibility of password expiration reset link (3.96 KB, patch)
2024-08-21 12:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37691: Improve visibility of password expiration reset link (4.05 KB, patch)
2024-08-22 12:33 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37691: Improve visibility of password expiration reset link (4.09 KB, patch)
2024-08-22 17:31 UTC, Sam Lau
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chanel Wheeler 2024-08-20 17:26:45 UTC
Created attachment 170502 [details]
password expiration screen

When passwords expire, the GUI for changing it isn't clear enough to staff. 

1. Some staff don't see the "You must reset your password" string.
2. Those that do see it, don't realize it's a link.
3. They try to enter a new password in the login form which sends them in a loop back to where they are.

I just went through this with 59 libraries. It was a flurry of emails all morning. Reset your password really should be a noticeable button and should take the place of the text fields so that they can't get it wrong. Thank you.
Comment 1 Owen Leonard 2024-08-21 11:41:44 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2024-08-21 12:02:24 UTC
Created attachment 170561 [details] [review]
Bug 37691: Improve visibility of password expiration reset link

This patch moves the password expiration reset link into the error box
so that it is more prominent.

To test, apply the patch and attempt to log in to the staff interface as
a user whose password has expired. You will probably have to use SQL to
update a patron record directly, e.g.

UPDATE borrowers SET password_expiration_date = '2022-01-01' WHERE borrowernumber = X;

When you submit your login details the page should reload with an error
message: "Error: Your password has expired." Within the red dialog you
should see the "You must reset your password" link.

Sponsored-by: Athens County Public Libraries
Comment 3 Chanel Wheeler 2024-08-21 15:19:12 UTC
(In reply to Owen Leonard from comment #2)
> 
> When you submit your login details the page should reload with an error
> message: "Error: Your password has expired." Within the red dialog you
> should see the "You must reset your password" link.

Would it possible to reword it as "Reset your password" so that it's clear it's an action item?
Comment 4 Owen Leonard 2024-08-22 12:33:59 UTC
Created attachment 170606 [details] [review]
Bug 37691: Improve visibility of password expiration reset link

This patch moves the password expiration reset link into the error box
so that it is more prominent.

To test, apply the patch and rebuild the staff interface
CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface

Try to log in to the staff interface as a user whose password has
expired. You will probably have to use SQL to update a patron record
directly, e.g.

UPDATE borrowers SET password_expiration_date = '2022-01-01' WHERE borrowernumber = X;

When you submit your login details the page should reload with an error
message: "Error: Your password has expired." Within the red dialog you
should see the "You must reset your password" link.

Sponsored-by: Athens County Public Libraries
Comment 5 Sam Lau 2024-08-22 17:31:07 UTC
Created attachment 170613 [details] [review]
Bug 37691: Improve visibility of password expiration reset link

This patch moves the password expiration reset link into the error box
so that it is more prominent.

To test, apply the patch and rebuild the staff interface
CSS:
https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface

Try to log in to the staff interface as a user whose password has
expired. You will probably have to use SQL to update a patron record
directly, e.g.

UPDATE borrowers SET password_expiration_date = '2022-01-01' WHERE borrowernumber = X;

When you submit your login details the page should reload with an error
message: "Error: Your password has expired." Within the red dialog you
should see the "You must reset your password" link.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 6 Katrin Fischer 2024-09-02 09:00:41 UTC
QA'd by RM.
Comment 7 Katrin Fischer 2024-09-02 10:21:41 UTC
Pushed for 24.11!

Well done everyone, thank you!