Bug 3788 - XSLT does not obey viewISBD syspref
Summary: XSLT does not obey viewISBD syspref
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Chris Cormack
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-16 07:18 UTC by Jane Wagner
Modified: 2012-10-26 00:41 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch file (2.86 KB, patch)
2009-11-16 19:22 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:15:00 UTC


---- Reported by jwagner@ptfs.com 2009-11-16 19:18:10 ----

Related to the issues in 3098 and 3108, the MARC21slim2OPACDetail.xsl file does not obey the viewISBD syspref.  I've modified that file and XSLT.pm to pass that syspref value into the file and obey it for display.

Note that there is not a separate OPAC syspref for this, just the one viewISBD in the Staff group.  I don't see a reason to use a separate OPAC syspref.



---- Additional Comments From jwagner@ptfs.com 2009-11-16 19:22:28 ----

Created an attachment
patch file





---- Additional Comments From jwagner@ptfs.com 2009-11-16 19:22:54 ----

Patch sent November 16, 2009



---- Additional Comments From gmcharlt@gmail.com 2010-04-30 02:10:42 ----

Patch pushed.  Please test and close.



---- Additional Comments From jwagner@ptfs.com 2010-05-12 13:51:26 ----

The fix for this bug (in ptfs-harley) can also be pulled from the public git repository at http://github.com/Koha-PTFS, branch http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3788




--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:15 UTC  ---

This bug was previously known as _bug_ 3788 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3788
Imported an attachment (id=1572)

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was jmf@liblime.com.
The original submitter of attachment 1572 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Jane Wagner 2011-06-30 18:32:10 UTC
The OPAC in current head no longer obeys the syspref -- the ISBD tab shows regardless of the syspref's setting.
Comment 2 Owen Leonard 2011-08-24 13:11:36 UTC
The structure of the OPAC detail template no longer delegates display of the view menu to the XSL stylesheet. That makes this bug invalid in master (and invalid in 3.0.x by definition).
Comment 3 Owen Leonard 2011-08-24 13:13:54 UTC
Note that there is a bug to add an OPACISBD preference: Bug 5979.