If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions.
Created attachment 172341 [details] [review] Bug 38076: Fix inability of fast catalogers to add/edit FA framework records If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Attempt to create a fast cat item from the circ menu 3) Note the login screen and error 4) Apply this patch 5) Restart all the things! 6) Try again, you can now create FA records!
Created attachment 172363 [details] [review] Bug 38076: Fix inability of fast catalogers to add/edit FA framework records If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Attempt to create a fast cat item from the circ menu 3) Note the login screen and error 4) Apply this patch 5) Restart all the things! 6) Try again, you can now create FA records! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Thank for the SO Brendan!
Thanks for the quick patch! This is really important for our consortium the way we do centralized cataloging.
Created attachment 172368 [details] [review] Bug 38076: Fix inability of fast catalogers to add/edit FA framework records If a librarian does not have the editcatalogue permission, but does have the fast_cataloging permission, they should be able to add and edit fast cataloging records. Instead they are presented with a login screen and the message that they do not have sufficient permissions. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Attempt to create a fast cat item from the circ menu 3) Note the login screen and error 4) Apply this patch 5) Restart all the things! 6) Try again, you can now create FA records! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 172411 [details] [review] Bug 38076: (QA follow-up): Make permission edit_catalogue imply fast_cataloging Any librarian with the edit_catalogue sub-permission should also be able to edit fast catalog records. If that was not true, a cataloger could not convert fast adds into full records.
Pushed for 24.11! Well done everyone, thank you!
Well ok, but then you are moving up $op and introduces another bug. See bug 38211
Backported to 24.05.x for upcoming 24.05.05
Depends on Bug 37947 not in 23.11.x