---- Reported by nengard@gmail.com 2009-12-03 00:59:10 ---- Since there are permissions associated with the Fast Add Framework, it should not be allowed to be deleted - editing is okay - but deleting would cause problems I would think. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:15 UTC --- This bug was previously known as _bug_ 3831 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3831 Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Setting severity to normal - interface degrades gracefully if there's no FA framework.
lowering severity again : * degrades gracefully * with great power comes great responsibility, only one librarian usually has access to this part of Koha
I think if we remove the option to delete it, we would also have to make it mandatory in the web installer. But not sure we should as long as it doesn't seem to cause problems.
Created attachment 37209 [details] [review] Bug 3831: Does not allow to delete the FA framework Test plan: Go on the MARC framework list view and confirm there is no Delete link anymore for the FA framework.
Created attachment 37252 [details] [review] [Signed-off] Bug 3831: Does not allow to delete the FA framework Test plan: Go on the MARC framework list view and confirm there is no Delete link anymore for the FA framework. Delete link for Fast add framework does no longer display. Signed-off-by: Marc Véron <veron@veron.ch> http://bugs.koha-community.org/show_bug.cgi?id=13831
Perhaps it should also be required when doing a fresh install? (This might be the case... I just noticed on a 3.18.5 install that I could choose not to install the FA framework.)
Created attachment 37326 [details] [review] Bug 3831 - Move fast add framework from optional to mandatory
I'm not entirely sure this is a good idea. Can anyone demonstrate an actual error caused by not having the fast cataloging framework? I've found if I delete it, and check out a nonexistant barcode, the fast cataloging link will take me to the marc editor with a blank page, where I can choose a different framework. Would it not be better to handle the case where there is no FA framework installed instead?
(In reply to Kyle M Hall from comment #8) > Would it not be better to handle the case where there is no FA framework > installed instead? If it is mandatory and we remove the delete action, we should not take into account this case (even if it could appears for existing installations...).
(In reply to Kyle M Hall from comment #8) > (...) I've found if I > delete it, and check out a nonexistant barcode, the fast cataloging link > will take me to the marc editor with a blank page, where I can choose a > different framework. (...) Hmm, should the link 'Fast cataloging' be available/visible if no FA framework is defined? I think no, because of following code in circ/circulation.pl (around line 536) my $fast_cataloging = 0; if (defined getframeworkinfo('FA')) { $fast_cataloging = 1 } So if you can trigger the link without having a FA framework, there must be some bug (condition 'defined' or return value of getframeworkinfo?). Regarding the question optional vs. mandatory: Maybe we could keep the FA framework optional and display a warning on page 'About Koha', Tab 'System information' if the FA framework is missing.
(In reply to Kyle M Hall from comment #8) > I'm not entirely sure this is a good idea. Can anyone demonstrate an actual > error caused by not having the fast cataloging framework? I've found if I > delete it, and check out a nonexistant barcode, the fast cataloging link > will take me to the marc editor with a blank page, where I can choose a > different framework. > > Would it not be better to handle the case where there is no FA framework > installed instead? That's a good point. Maybe it is best to just warn that the framework is missing.
Trying to free this from In discussion by agreeing with the last 2 comments :)
Created attachment 147741 [details] [review] Bug 3831: Add a warning to about page when there is no FA framework The feature is effectively disab;ed throughout Koha when this framework is deleted. There do not appear to be any other side effects. We should report this on the about page for informatinal purposes To test: 1 - Apply patch 2 - Check about page, no change 3 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FB' WHERE frameworkcode = 'FA' 4 - Refresh about page 5 - Note new warning 6 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FA' WHERE frameworkcode = 'FB' 7 - Refresh about page 8 - No warning
Created attachment 147744 [details] [review] Bug 3831: Add a warning to about page when there is no FA framework The feature is effectively disab;ed throughout Koha when this framework is deleted. There do not appear to be any other side effects. We should report this on the about page for informatinal purposes To test: 1 - Apply patch 2 - Check about page, no change 3 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FB' WHERE frameworkcode = 'FA' 4 - Refresh about page 5 - Note new warning 6 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FA' WHERE frameworkcode = 'FB' 7 - Refresh about page 8 - No warning Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Created attachment 148024 [details] [review] Bug 3831: Add a warning to about page when there is no FA framework The feature is effectively disab;ed throughout Koha when this framework is deleted. There do not appear to be any other side effects. We should report this on the about page for informatinal purposes To test: 1 - Apply patch 2 - Check about page, no change 3 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FB' WHERE frameworkcode = 'FA' 4 - Refresh about page 5 - Note new warning 6 - sudo koha-mysql kohadev UPDATE biblio_framework SET frameworkcode = 'FA' WHERE frameworkcode = 'FB' 7 - Refresh about page 8 - No warning Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
And another 4-digit bug bites the dust :)
Pushed to master for 23.05. Nice work everyone, thanks!
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release