---- Reported by nengard@gmail.com 2009-12-03 15:41:15 ---- Created an attachment ACQ error When you're adding items to your basket if you don't have an ACQ framework you're presented with an error: "No ACQ framework, using default. You should create a framework with code ACQ, the items framework would be used" First - I'm not sure what this "the items framework would be used" means, but more importantly we should just have an ACQ framework by default in the system that the librarians can change to their needs so that this error doesn't appear the first time they enter Acquisitions. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:15 UTC --- This bug was previously known as _bug_ 3841 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3841 Imported an attachment (id=1601) Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. The original submitter of attachment 1601 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
Still valid, changing version to master.
*** Bug 3843 has been marked as a duplicate of this bug. ***
Created attachment 68635 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists.
Created attachment 68636 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists.
Created attachment 68637 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists.
Created attachment 68638 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists.
Created attachment 68806 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
I started looking at this yesterday and was wondering why the framework was sometimes mandatory and sometimes optional. Also: I think we could choose nicer defaults for the ACQ framework, like setting default for not for loan to -1 = on order and remove some fields from display that are very unlikely to be set on order time. Should I open a separate bug report for those suggestions? I think -1 would be really nice to have, otherwise it's just the same as now, but witout the helpful warning on how to change things.
I think a first step would be to have a ACQ framework that does not introduce regression and remove the warning message. This is what does the patch. The need here was bug 19289. If ACQ needs to be improved/tweaked, I think it should be done on a separate bug report (maybe it will depend on the MARC flavour, languages, etc.?)
Created attachment 69057 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
Created attachment 69138 [details] [review] Bug 3841: Add the ACQ framework for new installations This patch adds the acquisition frameworks (frameworkcode=ACQ) for new installations. It copies the 952 (MARC21) or 995 (UNIMARC) fields from the default framework (frameworkcode='') Test plan: Create a new installation and make sure the ACQ framework exists. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 18.05, thanks to everybody involved!
Awesome work all! Pushed to stable for 17.11.01
Created attachment 73947 [details] [review] Bug 3841: (follow-up) Add the ACQ framework for pl-PL No idea why I missed pl-PL!
(In reply to Jonathan Druart from comment #14) > Created attachment 73947 [details] [review] [review] > Bug 3841: (follow-up) Add the ACQ framework for pl-PL > > No idea why I missed pl-PL! Pushed to master for 18.05
Pushed to stable for 17.11.06 Awesome work all!
Not in 17.05.x