---- Reported by oleonard@myacpl.org 2009-12-08 15:48:44 ---- If you happen to delete something that has been placed in your cart, viewing the contents of your cart will generate an error: Can't call method "field" on an undefined value at kohaclone/C4/Biblio.pm line 1336. The user then has no way of removing the offending item from the cart. Perhaps the cart should simply ignore biblionumbers which are not found? --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:16 UTC --- This bug was previously known as _bug_ 3873 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3873 Actual time not defined. Setting to 0.0
lowering the severity, the use case is pretty rare. But keeping it open, as it's still relevant
I've added a bug 11032 to address the susceptability of Biblio.pm to abort in such cases leaving the calling routines unable to clean up sensibly
Created attachment 37205 [details] [review] Bug 3873: Avoid software error if the cart contains a deleted record If a record is placed in the basket and deleted, the basket view exploded with: Can't use an undefined value as an ARRAY reference at /home/koha/src/basket/basket.pl line 73. Test plan: 1/ Add some records to the basket 2/ Delete one of them 3/ Look at your basket It should not exploded Note that the number of items in the basket is now wrong.
Created attachment 37208 [details] [review] [Signed-off] Bug 3873: Avoid software error if the cart contains a deleted record If a record is placed in the basket and deleted, the basket view exploded with: Can't use an undefined value as an ARRAY reference at /home/koha/src/basket/basket.pl line 73. Test plan: 1/ Add some records to the basket 2/ Delete one of them 3/ Look at your basket It should not exploded Note that the number of items in the basket is now wrong. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Oh, there are more Softwre errors if you - try to send the basket: Can't use an undefined value as an ARRAY reference at /usr/share/kohaclone/basket/sendbasket.pl line 83. - try to download as ISO2709: Can't call method "as_usmarc" on an undefined value at /usr/share/kohaclone/basket/downloadcart.pl line 71. - try to download as RIS: An error has occurred! Error 500 - try to download as Bibtex Can't call method "subfield" on an undefined value at /usr/share/kohaclone/C4/Record.pm line 658.
Created attachment 37219 [details] [review] Bug 3873: follow-up for all other pages This should fix the issue on other pages. Test plan: Try to download and export the basket (intranet+opac sides).
Created attachment 37220 [details] [review] [Signed-off] Bug 3873: follow-up for all other pages This should fix the issue on other pages. Test plan: Try to download and export the basket (intranet+opac sides). Re-tested for errors in comment #5, they do not longer appear. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37322 [details] [review] [PASSED QA] Bug 3873: Avoid software error if the cart contains a deleted record If a record is placed in the basket and deleted, the basket view exploded with: Can't use an undefined value as an ARRAY reference at /home/koha/src/basket/basket.pl line 73. Test plan: 1/ Add some records to the basket 2/ Delete one of them 3/ Look at your basket It should not exploded Note that the number of items in the basket is now wrong. Works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37323 [details] [review] [PASSED QA] Bug 3873: follow-up for all other pages This should fix the issue on other pages. Test plan: Try to download and export the basket (intranet+opac sides). Re-tested for errors in comment #5, they do not longer appear. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patches pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.6