Bug 3908 - Edit subscription page shows manual history block by default
Summary: Edit subscription page shows manual history block by default
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-11 04:49 UTC by Owen Leonard
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (1.14 KB, patch)
2010-01-21 15:17 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:20:52 UTC


---- Reported by oleonard@myacpl.org 2009-12-11 16:49:33 ----

When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off.

The template checks for the "history" variable:

<!--TMPL_IF Name="history"--> $("#subscription_form_history").show();<!--/TMPL_IF-->

And the script defines "history" according to the operation. Line 110:

history => ($op eq 'mod'),

I would think the "history" variable should be defined based on the status of the "manual history" checkbox when the subscription was created?



---- Additional Comments From oleonard@myacpl.org 2010-01-21 15:17:47 ----

Created an attachment
Proposed fix

Changing check for "history" variable to check for "manualhistory."



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:20 UTC  ---

This bug was previously known as _bug_ 3908 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3908
Imported an attachment (id=1671)

Actual time not defined. Setting to 0.0
The original submitter of attachment 1671 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.