Bug 3926 - Managing suggestions: suggestion edit form combines data
Summary: Managing suggestions: suggestion edit form combines data
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-15 02:14 UTC by Owen Leonard
Modified: 2012-10-25 22:52 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (4.72 KB, patch)
2009-12-15 18:16 UTC, Chris Cormack
Details | Diff | Splinter Review
Additional fix (3.66 KB, patch)
2010-06-03 15:14 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:21:05 UTC


---- Reported by oleonard@myacpl.org 2009-12-15 14:14:22 ----

When editing a suggestion (suggestion/suggestion.pl?op=add) information is displayed about when the suggestion was managed. This information is passed to the template as one variable even though it consists of several individual elements:

my $presentation_string=$$member{firstname}." ".$$member{surname}." ".GetBranchName($$member{branchcode})." ".$$member{description}." ".$$member{category_type};

It would be better to pass each element to the template so that the display was more flexible.



---- Additional Comments From oleonard@myacpl.org 2009-12-15 18:16:09 ----

Created an attachment
Proposed fix





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3926 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3926
Imported an attachment (id=1690)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1690 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Owen Leonard 2010-06-03 15:14:29 UTC
Created attachment 2211 [details] [review]
Additional fix

The template-side fix for this bug was overwritten by another template change I submitted later. My bad.
Comment 2 Galen Charlton 2010-06-04 00:45:02 UTC
Patch pushed.  Please test and close.