---- Reported by nengard@gmail.com 2009-12-19 22:38:01 ---- At the top of the budgets page there is a search budgets box - no matter what I enter I get just a list of the budgets that were on the screen before searching. ---- Additional Comments From nengard@gmail.com 2010-02-03 18:07:23 ---- This still doesn't work in the newest Head and I'm wondering what it is supposed to search - Root Budgets or Budgets - or both? --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC --- This bug was previously known as _bug_ 3969 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3969 Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
I think the search box is working, but there needs to be a 'no results found' page if nothing is found - instead it looks like it just doesn't change the page
I tested this on current master . I have 2 budgets: - Etat 2011 - Funds testing In this sequence. 1) When I search for "Funds testing" I end up in "Etat 2011" 2) When I search for nothing, it doesn't bring up all budgets like in other places in Koha, but nothing happens. 3) When I search for nonsense like 'agaögha' nothing happens. It's very confusing.
Created attachment 6100 [details] screenshot of budget search Retesting this on current master/3.6 1) UNCLEAR: The library pull down on top is empty for me on the budget start page. When I go to the list of funds for a budget, it shows my own library in addition to an empty value. I have added a fund for another library, restricted to none, but this library still does not show up in the pull down. 2) BUG: A search for '2011' from the start page only shows my funds for budget 'Oktober 2011'. September is ignored completely. Marking it active didn't change that. 3) BUG: A search for 'September' from the budget page shows my 'Oktober' funds? 4) BUG: A search from the 'September 2011' fund page for '2011' and 'Okober' does not work. I should bring me back to the Oktober funds list, but the page stays on the September funds. So this seems to be still totally broken. Bug was filed 2009-12-19 22:38:01 :(
*** Bug 4992 has been marked as a duplicate of this bug. ***
This bug is almost 2 years old now and still the budget search is unusable.
Created attachment 9198 [details] [review] Bug 3969: Budget search in acquisition doesn't work (string changes) String changes: - Correcting tab name from "Search budgets" to "Seach funds" - Changing search option from "Name" to "Fund code"
Created attachment 9199 [details] [review] Bug 3969: Budget search in acquisition does't work (search) Search term was never evaluated. Patch makes sure input param is correctly stored in the variable and changes comparison to be case insensitive. To test: - Check search for fund codes (case insensitive) works - Check search for fund code in combination with library works The budgets to be shown can depend on your permissions. Testing with with a superlibrarian should bring up all funds. Also fixes warns in the logs that appeared when viewing the funds for a budget without funds.
Created attachment 9202 [details] [review] [SIGNED-OFF] Bug 3969: Budget search in acquisition doesn't work (string changes) String changes: - Correcting tab name from "Search budgets" to "Seach funds" - Changing search option from "Name" to "Fund code" Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Strings look a-ok.
Created attachment 9203 [details] [review] [SIGNED-OFF] Bug 3969: Budget search in acquisition does't work (search) Search term was never evaluated. Patch makes sure input param is correctly stored in the variable and changes comparison to be case insensitive. To test: - Check search for fund codes (case insensitive) works - Check search for fund code in combination with library works The budgets to be shown can depend on your permissions. Testing with with a superlibrarian should bring up all funds. Also fixes warns in the logs that appeared when viewing the funds for a budget without funds. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Funds are now searchable.
Both patches appear to work as explained. One thing I'm not sure about (but it's not stopping me from signing off since this is way better than it was when it didn't work at all) is why when I'm logged in as superlibrarian I can't search funds for branches other than the one I'm signed in at. Nicole
Hi Nicole, thx for signing off :) I wondered about the list of libraries too and I agree that it should show all libraries for a super librarian. Perhaps a separate bug?
Will do
First patch introduces string changes, and since we're after string freeze, this will need the RM's blessing. But, from a QA standpoint, it's fine, it's just template-level spacing and those few string changes. Second patch "(search)": moves param definition above action, so it gets processed. Cleans up some spacing, and provides some conditional checks on data before acting on it (to silence warns). Marking Passed QA.
That's why I kept string changes and functional fix in different patches - so we could patch the search, making it work. The label woudl still be wrong, but it would work. With the second patch, people would also know how to use it, but that coudl be pushed for 3.8.1.
Comment on attachment 9203 [details] [review] [SIGNED-OFF] Bug 3969: Budget search in acquisition does't work (search) This patch has been pushed, with a follow-up: the field name is budget_name, not name. The filter on budget name was not working correctly (the search on budget code was) Keeping "passed QA" to push the bug with string changes after 3.8.0 release
Patch pushed, but when testing it, i've found a bug : in aqbudgetperiod, the branch list is always empty. Seems the branches are loaded only in aqbudgets.pl Will mark patch pushed, but keep the bug open
The pull down is still empty on current master.
This bug appears to be valid in current master. Searching doesn't appear to work and the library selection dropdown is empty.
Created attachment 37191 [details] [review] Bug 3969: Fix funds search The funds search does not work at all. On the budget and the budget plan page, the library dropdown list is empty. Test plan: On the budget, the budget plan and the fund pages, confirm that you are able to search a fund by code (or name) and the library dropdown list is correctly filled.
When you visit the planning page you get this error: Software error: syntax error at /home/nengard/kohaclone/admin/aqplan.pl line 420, near "@hide_cols branchloop" Execution of /home/nengard/kohaclone/admin/aqplan.pl aborted due to compilation errors. For help, please send mail to the webmaster (webmaster@koha-vm), giving this error message and the time and date of the error.
Created attachment 37204 [details] [review] Bug 3969: Fix funds search The funds search does not work at all. On the budget and the budget plan page, the library dropdown list is empty. Test plan: On the budget, the budget plan and the fund pages, confirm that you are able to search a fund by code (or name) and the library dropdown list is correctly filled.
(In reply to Nicole C. Engard from comment #20) > When you visit the planning page you get this error: Sorry Nicole! I amended my patch with a last minute change, never a good idea...
Created attachment 37206 [details] [review] [Signed-off] Bug 3969: Fix funds search The funds search does not work at all. On the budget and the budget plan page, the library dropdown list is empty. Test plan: On the budget, the budget plan and the fund pages, confirm that you are able to search a fund by code (or name) and the library dropdown list is correctly filled. Tested with several combinations. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37250 [details] [review] [PASSED QA] Bug 3969: Fix funds search The funds search does not work at all. On the budget and the budget plan page, the library dropdown list is empty. Test plan: On the budget, the budget plan and the fund pages, confirm that you are able to search a fund by code (or name) and the library dropdown list is correctly filled. Tested with several combinations. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Tested various combinations, no problems found. Passes tests and QA script.
Patches pushed to master. Thanks Jonathan!
Pushed to 3.18.x will be in 3.18.6