Bug 3985 - New Sys Prefs Branch - Missing Acq Preferences
Summary: New Sys Prefs Branch - Missing Acq Preferences
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: PC All
: P5 - low critical (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-23 12:47 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch part 1 (1.96 KB, patch)
2010-02-05 13:19 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:21:46 UTC


---- Reported by nengard@gmail.com 2009-12-23 12:47:09 ----

Jesse, these preferences are missing on the Acq tab:

pdfformat
AcqCreateItem 
acquisitions
CurrencyFormat
emailPurchaseSuggestions
gist
OrderPdfFormat
OrderPdfTemplate

Also - I think that AnonSuggestion belongs there instead of OPAC - but I'm okay with it wherever you leave it.



---- Additional Comments From nengard@gmail.com 2009-12-23 12:56:17 ----

And this one: emailPurchaseSuggestions 



---- Additional Comments From colin.campbell@ptfs-europe.com 2010-02-04 10:09:07 ----

Upped severity. 



---- Additional Comments From nengard@gmail.com 2010-02-05 13:19:16 ----

Created an attachment
patch part 1

AcqCreateItem, CurrencyFormat, gist, and OrderPdfFormat back into the sys prefs interface. 

Still missing are acquisitions, OrderPdfTemplate, and emailPurchaseSuggestions.




---- Additional Comments From nengard@gmail.com 2010-02-05 13:32:13 ----

reassigned to Jesse because I'm stuck on how to add the preferences I didn't add.



---- Additional Comments From gmcharlt@gmail.com 2010-02-05 13:55:10 ----

OrderPdfFormat needs a more complete explanation - there's no guidance for the user on how and why to change its value.  Looking at the code, the two valid values are:

 layout2pages.pm
 layout3pages.pm

Some explanation from BibLibre would help explain those two options, as would guidance on how a library might produce a custom layout.



---- Additional Comments From nengard@gmail.com 2010-05-01 01:29:51 ----

I'm stuck on how to add a preference that lets you browse for files - this is not a preference type we've had before and so I'm not sure how to add in the missing OrderPdfTemplate preference.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3985 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3985
This bug blocked bug(s) 4188.
Imported an attachment (id=1744)

Actual time not defined. Setting to 0.0
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was pianohacker@gmail.com.
The original submitter of attachment 1744 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Galen Charlton 2010-07-02 19:47:51 UTC
OrderPdfTemplate has been dealt with per bug 4188.  I think that this bug can now be closed; please confirm.