Bug 3987 - New Sys Prefs Branch - Alphabetize prefs in sections
Summary: New Sys Prefs Branch - Alphabetize prefs in sections
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-23 01:07 UTC by Nicole C. Engard
Modified: 2012-10-25 22:52 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (2.85 KB, patch)
2010-06-02 18:21 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:21:48 UTC


---- Reported by nengard@gmail.com 2009-12-23 13:07:02 ----

The tabs are in alpha order and so the preferences should be as well.  Basically if you have sections under a tab the preferences should be in alpha order under each of those headings/sections.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3987 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3987

Actual time not defined. Setting to 0.0
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was pianohacker@gmail.com.
Bug reassigned, setting status to "NEW".
   Previous status was "ASSIGNED".

Comment 1 Nicole C. Engard 2010-06-02 12:07:54 UTC
I can resolve this by editing the *.pref files but I'm wondering if there is an automated way to make this happen.  Maybe a JS or something?
Comment 2 Owen Leonard 2010-06-02 18:21:31 UTC
Created attachment 2201 [details] [review]
Proposed fix

Adding jquery tablesorter, sorting on sys pref variable by default
Comment 3 Galen Charlton 2010-06-04 00:23:57 UTC
Pushed patch to new/bug3987_alpha_sysprefs topic branch for further testing and evaluation.  I confirm that the patch seems to do what it says it does.

I agree that it is desirable to be able to sort the sysprefs by name.  However, I am not as sure that alphabetical order should be the default order; a better default order might be to take advantage of the fact that the system preferences can be listed in any order to arrange them in a order that would make sense for a new librarian implementing Koha.

Consequently, I am requesting feedback.  I have no serious objection to having the order by alpha by default, although I don't think that was necessarily Jesse's intention, so if there is silence on this matter or general agreement that default alpha sorting is preferred, I'll accept a request to merge the branch in a few days.
Comment 4 Nicole C. Engard 2010-06-04 00:40:46 UTC
I actually talked to Jesse ages ago and he was starting to alpha them - but didn't get through them all.  I do agree that librarians should be allowed to move them around - but I also know librarians love their alpha order :)  The new division of categories within tabs makes it easier to find things, but some of those categories are still full of a lot of prefs making it hard to find the one you want without doing a 'find in page' which is what I find myself doing often - that or searching the prefs instead of browsing.
Comment 5 Katrin Fischer 2010-12-13 19:30:04 UTC
Librarians love alpha order - but please remember that Koha is translated in a lot of languages ;)

The alphabetic ordering of the English tabs does not work for us. Dynamic sorting using javascript might be a better option here.
Comment 6 Owen Leonard 2010-12-13 19:33:00 UTC
> The alphabetic ordering of the English tabs does not work for us. Dynamic
> sorting using javascript might be a better option here.

This bug and the accompanying patch do not address the order of the navigational tabs. The patch adds Javascript-based table sorting to the list of system preferences. Sorting will be based on your translated preference names.
Comment 7 Katrin Fischer 2010-12-13 19:35:32 UTC
Thx for the quick comment Owen. :)
Comment 8 Nicole C. Engard 2010-12-16 17:37:44 UTC
I have applied this patch and tested it - but I don't see any table sorter options when applied to head ... patch did apply cleanly though.
Comment 9 Nicole C. Engard 2010-12-17 15:47:57 UTC
nevermind me - it worked this morning :)
Comment 10 Chris Cormack 2010-12-18 18:25:49 UTC
Pushed, please test and fix