Bug 4000 - Budgets table doesn't show tree view for sub-budgets
Summary: Budgets table doesn't show tree view for sub-budgets
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Bugs List
URL: admin/aqbudgets.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-23 04:58 UTC by Owen Leonard
Modified: 2015-06-04 23:23 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot (45.88 KB, image/png)
2011-10-29 09:09 UTC, Katrin Fischer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:21:58 UTC


---- Reported by oleonard@myacpl.org 2009-12-23 16:58:07 ----

On admin/aqbudgets.pl, the table of budgets should display budgets with sub-budgets using a javscript-based tree view. In the template:

<!-- TMPL_IF NAME="notree" -->
...
<!-- TMPL_ELSE -->
  $("#budgeth").treeTable();
<!-- /TMPL_IF -->

"notree" must always evaluate as true, because I don't see the tree view under any circumstances. If I take out the conditional and force the treeTable() function the tree view displays as I think it should.



---- Additional Comments From oleonard@myacpl.org 2009-12-23 17:08:02 ----

More details: The budgets listing defaults to a state where "show my budgets only" is selected (this is with IndependentBranches OFF if it matters). If I resubmit with "show my budgets only" deselected I see the tree view.

Line 76 of aqbudgets.pl:

$template->param(
    notree => ($filter_budgetbranch or $show_mine)
);

Is that because the tree view doesn't work if your budget's parent isn't "yours" or your library's?



---- Additional Comments From nahuel.angelinetti@biblibre.com 2009-12-30 10:51:10 ----

You don't have a tree if you select only your budgets(parents budgets are not every time yours), like this:
 * Jane
   * Jack
     * Mine
   * Mine
     * Jack
   



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 4000 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4000

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Katrin Fischer 2011-10-28 18:05:26 UTC
I have never seen a tree like view in acq. Owen, can you confirm?
Comment 2 Owen Leonard 2011-10-28 18:13:59 UTC
> I have never seen a tree like view in acq.

Hence the bugs! The template hasn't changed since I first filed this bug. There's something going on here that doesn't work.
Comment 3 Katrin Fischer 2011-10-29 09:09:06 UTC
Created attachment 6109 [details]
screenshot

Ok, while playing with budget search I found out, that when you remove the 'my funds only' option in the filters, the tree view shows up.

I think one confusing part of this is, that the checkbox sets itself when you search for something. If we really want it to default to that, it should be checked consistently on all pages.
Comment 4 Katrin Fischer 2011-10-29 09:27:29 UTC
Ok, I think I got confused. The checkbox seems to be always set - so it's consistent.
Comment 5 Katrin Fischer 2014-07-12 09:43:16 UTC
I believe this was fixed by bug 11578.