Bug 4028 - OPAC search history available to non-logged-in users
Summary: OPAC search history available to non-logged-in users
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Matthias Meusburger
QA Contact: Bugs List
URL: /cgi-bin/koha/opac-search-history.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-01-06 02:04 UTC by Owen Leonard
Modified: 2012-10-25 22:52 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (3.70 KB, patch)
2010-01-06 15:45 UTC, Chris Cormack
Details | Diff | Splinter Review
Alternate patch (9.54 KB, patch)
2010-01-07 15:05 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:22:18 UTC


---- Reported by oleonard@myacpl.org 2010-01-06 14:04:54 ----

There is no link to opac-search-history.pl shown to non-logged-in users, but one could enter the link manually and see a search history of yourself and potentially all the other users of, for instance, a public OPAC station.

One solution would be to provide a means for non-logged-in users to clear their search history, but I think such users have an expectation of privacy and they should not be asked to "opt out."

opac-search-history.pl should have its access limited to logged-in users.



---- Additional Comments From matthias.meusburger@biblibre.com 2010-01-06 15:45:23 ----

Created an attachment
Patch

The "search history" link and the "delete history" link are now correctly displayed after the first search.
Moreover, an additional "delete history" link has been added on the "search history" page itself.




---- Additional Comments From oleonard@myacpl.org 2010-01-07 15:05:29 ----

Created an attachment
Alternate patch

This patch for http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4024 incorporates the changes from Matthias's patch and adds fixes for http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4028.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:22 UTC  ---

This bug was previously known as _bug_ 4028 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4028
Imported an attachment (id=1788)
Imported an attachment (id=1789)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1788 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1789 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.