---- Reported by nengard@gmail.com 2010-01-11 17:18:20 ---- Often things are organized in the library based on item type so if you want to do inventory in one area of the library you want to limit by item type - also it was something that was there before, so it seems silly to remove it at this point. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:22 UTC --- This bug was previously known as _bug_ 4037 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4037 Actual time not defined. Setting to 0.0 CC member jwagner@ptfs.com does not have an account here
still relevant
still relevant in master and 3.12 M. Saby
Issue still exist in 16.05
Still valid.
Created attachment 115230 [details] [review] Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ)
Created attachment 115231 [details] [review] Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com>
Created attachment 116414 [details] [review] Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 116415 [details] [review] Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 116512 [details] [review] Bug 4037: Correctly join the itemtypes array
Created attachment 116513 [details] [review] Bug 4037: Correctly join the itemtypes array
Created attachment 116514 [details] [review] Bug 4037: Remove hardcoded 4 columns
Katrin, can you review those 2 last patches? I am quite confident with the first one. The second one remove the weirdness in the template to try and display correctly the item types. Don't we have other places we item types are displayed? On the adv search there are the icons, should we have them here as well?
(In reply to Jonathan Druart from comment #12) > Katrin, can you review those 2 last patches? > > I am quite confident with the first one. > > The second one remove the weirdness in the template to try and display > correctly the item types. Don't we have other places we item types are > displayed? On the adv search there are the icons, should we have them here > as well? I think having the icons here would be too much "clutter", having the descriptions is enough I think. We do a grid display of libraries and something for itemtypes in columns on the advanced search page. We'll try to retest. I am not sure removing the lines in the second patch is right from glancing at it, but will look at a full template to see how things fit together.
> I think having the icons here would be too much "clutter", having the > descriptions is enough I think. > We do a grid display of libraries and something for itemtypes in columns on > the advanced search page. We'll try to retest. We do a grid display of libraries ... on the export tool. Gr.
Indeed, obsoleting it.
Created attachment 116522 [details] [review] Bug 4037: Add item type filter to inventory tool This patch adds the ability to filter inventory by item type. Multiple item types can be selected at once. To test: 1) Apply patch and restart services. 2) Set up (at least) one item of a specific item type. 3) Go to Tools -> Inventory. 4) Scroll down to find the item types filter. Confirm the 'select all' and 'clear all' buttons work as expected. 5) Select a few item types, but DO NOT include the item type that you just set for your item. Confirm that your item does not show in the results. 6) Go back to the Inventory tool. This time submit a search that DOES include the item type you just set for your item. Confirm that your item does show in the results. 7) Confirm tests pass: prove t/db_dependent/Items/GetItemsForInventory.t Sponsored-by: Bibliotheksservice-Zentrum Baden-Württemberg (BSZ) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Created attachment 116523 [details] [review] Bug 4037: Correctly join the itemtypes array Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
It works well for me with the follow-up.
Pushed to master for 21.05, thanks to everybody involved!
In my opinion, SQL query should depend on preference 'item-level_itypes', like for example in GetTopIssues : https://git.koha-community.org/Koha-community/Koha/src/commit/40ccb7f37138e0bf31345608459eb7a9ba666027/C4/Circulation.pm#L4197 I know its wrong, but sometimes we see datas other than itemtypes in biblioitems.itemtype (when itemtype on item level)