Bug 4102 - import_borrowers.pl fails silently
Summary: import_borrowers.pl fails silently
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: PC All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Chris Nighswonger
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-03 07:23 UTC by Chris Nighswonger
Modified: 2019-06-27 09:24 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Code to verify columns and terminate import on fatal errors (48.58 KB, patch)
2010-02-10 17:14 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:23:11 UTC


---- Reported by cnighswonger@foundations.edu 2010-02-03 19:23:45 ----

When importing a csv with some columns which do not match db fields, import_borrowers.pl will report success if some columns match while silently failing to import columns which do not match.

Rather than silently failing, the script should return an error noting the column names which do not match and refusing to import anything until all columns match db fields.

At present there is a mechanism in place for checking certain "mandatory" columns, but no validation check for all columns.



---- Additional Comments From cnighswonger@foundations.edu 2010-02-10 17:14:21 ----

Created an attachment
Code to verify columns and terminate import on fatal errors





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:23 UTC  ---

This bug was previously known as _bug_ 4102 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4102
Imported an attachment (id=1836)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1836 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Chris Nighswonger 2010-06-03 17:03:33 UTC
This patch appears to have been dropped.

Please push so that this bug can be closed.