Add data as expected... Signing off.

First patch is okay, just adds ccode to the stats table so you don't have to do a multi-table join to get it from items and deleteditems.

The database update, though, looks a little janky:

ALTER TABLE `statistics` ADD `ccode` VARCHAR( 80 ) NULL ;

should be more like 

ALTER TABLE `statistics` ADD COLUMN `ccode` VARCHAR ( 10 ) AFTER `associatedborrower`

The update message is also inaccurate ("Category code" instead of "collection code")

QA comment:

Why do you have 
+
+=item DropAllForeignKeys($table)
+
in 1st patch ?

Other than this, it's OK, and it passes
../qa/koha-qa.pl -c 3

answer my previous question (and remove it if it was not intended) to earn "passed QA"

(In reply to comment #12)
> QA comment:
> 
> Why do you have 
> +
> +=item DropAllForeignKeys($table)
> +
> in 1st patch ?

That was an accident. I'll add another followup to remove it.

QA comment: I was about to push your patch (after squashing the 2 last follow-up and adding a removal of useless `` in updatedatabase), and, at the end, I won't, because I've found a tiny mistake:

The update says:
UPDATE statistics SET statistics.ccode = ( SELECT items.ccode FROM items WHERE statistics.itemnumber = items.itemnumber )

which seems OK

OTOH you record a ccode only in Circulation.pm, which seems OK (you don't need to record the item ccode when a fine is paid, so nothing changed in C4::Accounts.pm)

BUT: when you pay a fine because of a lost item, the itemnumber field *can* be set.
In this case, you will have an itemnumber, but no ccode. Your updatedatabase will populate ccode anyway.

So, 2 options:
  * populate ccode in Accounts.pm, when there is an item
  * UPDATE by discarding statistics.type='payment' or 'writeoff' (maybe there are other values, not 100% sure)

Please choose and resubmit. I suggest you squash the 4 current patches, and add a follow-up for this QA question

> So, 2 options:
>   * populate ccode in Accounts.pm, when there is an item
>   * UPDATE by discarding statistics.type='payment' or 'writeoff' (maybe
> there are other values, not 100% sure)
> 
> Please choose and resubmit. I suggest you squash the 4 current patches, and
> add a follow-up for this QA question

Since a payment may be for multiple items, I don't think we should add a ccode for payments, so I have chosen the latter option.

I have also squashed the earlier patches per your suggestion.

Patch pushed to master

My database does not contain ccode, so I could not check that the updatedatabase really worked properly (at least the column is created)

A nice follow-up could be to have the line "collection" not visible on reports/issues_stats.pl is there is nothing in the list. But it's not worth failing QA for that ;-)

follow up needs sign off.

Created attachment 12793 [details] [review]
[SIGNED-OFF] Bug 4118: Follow up: Add ccode to kohastructure for stats

CCode was added to the statistics table in this bug, but
was not added to kohastructure.sql. This patch adds it
with comment to the kohastructure.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Change back to enhancement after pushed, but marked critical right now.

Comment on attachment 12795 [details] [review]
Follow up to Bug 8585: add missing word to preference

Attached to the wrong bug.

Add the new field statistics.ccode to kohastructure.
Marked as Passed QA.

follow-up pushed, (back to ENH)