Bug 4139 - overdue notice generation performance issue
Summary: overdue notice generation performance issue
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: rel_3_2
Hardware: PC All
: PATCH-Sent (DO NOT USE) blocker (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL: circ/overdue.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-08 05:46 UTC by Galen Charlton
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:23:36 UTC


---- Reported by gmcharlt@gmail.com 2010-02-08 17:46:28 ----

Commit 943aa38564c tries to address a performance issue in the display and search of extended patron attributes during overdue notice generation by disabling a feature that had been sponsored by a library (added in commit ab44e2986a0).

On initial glance, adding additional indexes to authorised_values, borrower_attributes, and borrower_attribute_types should improve the performance of the query.

Note to all re regarding 943aa38564c: if you find a performance problem, please don't simply disable a feature - please fix the actual problem.  The performance issue is real, hence I'm marking this as a blocker for 3.2.



---- Additional Comments From gmcharlt@gmail.com 2010-02-10 15:46:49 ----

I will work on the database updates.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:23 UTC  ---

This bug was previously known as _bug_ 4139 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4139

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Chris Cormack 2010-06-16 02:48:15 UTC
Galen, does this still need to be done? If so I can work on the update script
Comment 2 Chris Cormack 2010-07-06 08:58:18 UTC
Ok, a couple of indexes make a big difference

create index auth_value_idx on authorised_values (authorised_value);
create index auth_val_cat_idx on borrower_attribute_types (authorised_value_category);

Before the indexes

55599 rows in set (2.77 sec)

After

55599 rows in set (0.62 sec)

Will update the kohastructure.sql and and updatedatabase.pl
Comment 3 Galen Charlton 2010-07-06 12:28:43 UTC
Pushed fix.  Performance gain is good enough for me, so closing.