---- Reported by nengard@gmail.com 2010-02-23 17:13:22 ---- Created an attachment pull down without zips Many cities have multiple zip codes, but the pull down on the patrons page only shows the city, state - not the zip - so you see duplicates and triplicates and have no idea which is the right one. ---- Additional Comments From nengard@gmail.com 2010-02-23 17:13:42 ---- Created an attachment cities admin with zip ---- Additional Comments From nengard@gmail.com 2010-02-23 18:38:06 ---- reassigning because I looked into this and it's not a template issue - it's a db function issue - the function only returns city,state - and I don't know how to fix it to return the zip as well. ---- Additional Comments From gcollum@gmail.com 2010-02-24 01:12:51 ---- Created an attachment Proposed patch ---- Additional Comments From colin.campbell@ptfs-europe.com 2010-02-24 15:57:52 ---- The routine is also adding two blank lines instead of one. Working on a patch which incorporates Garry's fix and also removes the extra empty option and hopefully leaves GetCities a clearer piece of code. ---- Additional Comments From colin.campbell@ptfs-europe.com 2010-02-24 16:58:02 ---- Created an attachment Proposed Patch Reworked the underlying routine to have a cleaner interface. Hopefully the code is more maintainable now. ---- Additional Comments From gmcharlt@gmail.com 2010-04-30 02:21:51 ---- Pushed Colin's patch. Please test and close. ---- Additional Comments From oleonard@myacpl.org 2010-04-30 16:50:02 ---- Created an attachment Follow-up patch with markup corrections - Missing "=" in attribute - TMPL_IF nested in HTML tag, which breaks translation script ---- Additional Comments From gmcharlt@gmail.com 2010-04-30 21:07:40 ---- Pushed Owen's follow-up. ---- Additional Comments From nengard@gmail.com 2010-05-01 01:16:02 ---- looks great --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:24 UTC --- This bug was previously known as _bug_ 4248 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4248 Imported an attachment (id=1944) Imported an attachment (id=1945) Imported an attachment (id=1946) Imported an attachment (id=1947) Imported an attachment (id=1948) Actual time not defined. Setting to 0.0 The original submitter of attachment 1944 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. The original submitter of attachment 1945 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. The original submitter of attachment 1946 [details] [review] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. The original submitter of attachment 1947 [details] [review] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz. The original submitter of attachment 1948 [details] [review] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz.