Bug 4314 - Flag for SSL Enabled to fix 3rd Party Enhanced Content in OPAC
Summary: Flag for SSL Enabled to fix 3rd Party Enhanced Content in OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Chris Cormack
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-10 03:09 UTC by Jane Wagner
Modified: 2012-10-25 22:52 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch file (35.56 KB, patch)
2010-03-12 13:55 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:25:42 UTC


---- Reported by jwagner@ptfs.com 2010-03-10 15:09:33 ----

Reported by and initial code worked out by Chris Hyde, East Brunswick Public Library, East Brunswick, NJ, USA.

If a library has enabled SSL encryption in the OPAC, Syndetics and LibraryThing links give error messages in Internet Explorer.  The proposed fix is to add a syspref for OPAC SSL in use.  Then check that syspref and pass the value to the OPAC template.  If it is on, have the Syndetics and LibraryThing links use the https form of URL; otherwise, leave them at the http form of URL.

Any other 3rd party content where this would be useful?



---- Additional Comments From katrin.fischer@bsz-bw.de 2010-03-10 15:44:18 ----

This is also a problem with Amazon, but not sure if this solution will work there too.



---- Additional Comments From jwagner@ptfs.com 2010-03-10 16:35:45 ----

We discussed on the IRC and gmcharlt had a better approach, a check in Auth.pm to see if SSL is in use.  He's sent a patch for that part.  I'm working on a patch for Syndetics and LibraryThing calls in the OPAC templates.  I don't know what URLs might be needed for other providers like Amazon; if someone else does, similar changes could be made for those calls.




---- Additional Comments From jwagner@ptfs.com 2010-03-12 13:55:24 ----

Created an attachment
patch file

Tested on a system with SSL enabled, and patch sent March 12, 2010.  Note that this patch only adds the SSL check for Syndetics and LibraryThing URLs.  I don't know if other enhanced content providers like Amazon or Baker & Taylor use different URLs, or if so, what those URLs are.  Someone else could easily continue the work for those URLs by following the basic logic used in this patch:

<!-- TMPL_IF NAME="using_https" -->
(link to https version of URL)
<!--TMPL_ELSE -->
(link to standard http version of URL)
<!-- /TMPL_IF -->

The URLs appear in several template files, so you'd need to check all of them.






---- Additional Comments From jwagner@ptfs.com 2010-03-12 13:57:05 ----

Note that this patch replicates the patch Galen Charlton sent on March 10 -- I couldn't get that to apply properly, and it was only a one-line change anyway so I just copied it.




---- Additional Comments From gmcharlt@gmail.com 2010-03-17 00:26:17 ----

Pushed patches to HEAD.  Please test and close.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:25 UTC  ---

This bug was previously known as _bug_ 4314 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4314
Imported an attachment (id=2002)

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was jwagner@ptfs.com.
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Bug reassigned, setting status to "NEW".
   Previous status was "ASSIGNED".
The original submitter of attachment 2002 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.