Bug 4321 - C4::Biblio::GetBiblio is badly coded
Summary: C4::Biblio::GetBiblio is badly coded
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.10
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Mason James
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-18 01:27 UTC by Nahuel Angelinetti
Modified: 2013-12-05 20:06 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 4321: clean C4::Biblio::GetBiblio and uses (5.81 KB, patch)
2012-07-24 13:40 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 4321: clean C4::Biblio::GetBiblio and uses (5.87 KB, patch)
2012-08-03 17:11 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 4321: clean C4::Biblio::GetBiblio and uses (5.99 KB, patch)
2012-08-27 17:19 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:25:47 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2010-03-18 13:27:03 ----

This function of C4::Biblio API is badly coded...



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:25 UTC  ---

This bug was previously known as _bug_ 4321 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4321

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Owen Leonard 2010-07-07 15:31:58 UTC
Original patch here: http://lists.koha-community.org/pipermail/koha-patches/2010-March/011479.html ...followed by some discussion. It appears this patch has not been approved for 3.0.x or HEAD.
Comment 2 Jonathan Druart 2012-07-24 13:40:17 UTC Comment hidden (obsolete)
Comment 3 Kyle M Hall (khall) 2012-08-03 17:11:01 UTC Comment hidden (obsolete)
Comment 4 Jared Camins-Esakov 2012-08-27 17:19:20 UTC
Created attachment 11849 [details] [review]
Bug 4321: clean C4::Biblio::GetBiblio and uses

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Comment 5 Mason James 2012-09-16 13:51:13 UTC
(In reply to comment #4)
> Created attachment 11849 [details] [review]
> Bug 4321: clean C4::Biblio::GetBiblio and uses
> 
> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
> Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

nice patch!, passing QA…

$ koha-qa.pl  

testing 1 commit(s) (applied to commit 2a60d49)
 * fb741a8 Bug 4321: clean C4::Biblio::GetBiblio and uses
      C4/Biblio.pm
      C4/ILSDI/Services.pm
      C4/ImportBatch.pm
      C4/Serials.pm
      catalogue/imageviewer.pl
      catalogue/issuehistory.pl
      opac/opac-imageviewer.pl

* C4/Biblio.pm                                                             OK
* C4/ILSDI/Services.pm                                                     OK
* C4/ImportBatch.pm                                                        OK
* C4/Serials.pm                                                            OK
* catalogue/imageviewer.pl                                                 OK
* catalogue/issuehistory.pl                                                OK
* opac/opac-imageviewer.pl                                                 OK
Comment 6 Paul Poulain 2012-09-18 10:20:27 UTC
Patch pushed to master
(my opinion = not needed to push this to 3.8, it's just code cleaning. we will have time to find any unspotted problem)

Thanks for this code cleaning !
Comment 7 Chris Cormack 2013-04-22 08:43:54 UTC
Released in 3.10.0