Bug 4325 - Standardize buttons cancel
Summary: Standardize buttons cancel
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.4
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Arnaud
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-19 02:30 UTC by Chris Cormack
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Standardize cancel buttons (2.89 KB, patch)
2010-03-19 14:48 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:25:51 UTC


---- Reported by alex.arnaud@biblibre.com 2010-03-19 14:30:08 ----

Cancel buttons look like links. must make them look like real buttons with the red cross.



---- Additional Comments From oleonard@myacpl.org 2010-03-19 14:35:27 ----

They are supposed to be styled as links. In most cases, the "cancel" action is not any kind of form submission, it's just a link back to a view or whatever the previous action was. In cases where a form submission might be required, styling the action to match existing patterns gives us a button styled like a link.

In addition, the distinctly different style of the "cancel" action is a visual cue to users that the action isn't the primary one: Users do not have to spend a long time examining the labels to determine which button is the submit and which is the cancel. This should reduce errors.

I don't believe this should be changed.



---- Additional Comments From alex.arnaud@biblibre.com 2010-03-19 14:48:16 ----

Created an attachment
Standardize cancel buttons 





---- Additional Comments From jeanandre.santoni@biblibre.com 2010-03-19 15:01:07 ----

(In reply to comment #1)
> They are supposed to be styled as links. In most cases, the "cancel" action is
> not any kind of form submission, it's just a link back to a view or whatever
> the previous action was. In cases where a form submission might be required,
> styling the action to match existing patterns gives us a button styled like a
> link.
Yes but, what you said is usefull for people who understand http, post data and so. Many librarians are more used to heavy client apps. And in these apps, written with toolkits like GTK or QT, cancel actions are buttons too.
> 
> In addition, the distinctly different style of the "cancel" action is a visual
> cue to users that the action isn't the primary one: Users do not have to spend
> a long time examining the labels to determine which button is the submit and
> which is the cancel. This should reduce errors.
I understand your point of view but the addition of this red cross is far more expressive than printing a simple link. Don't you think?

People are used to see these symbols, and many CMS (like Drupal for exemple) display buttons instead of links for the cancel action.





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:25 UTC  ---

This bug was previously known as _bug_ 4325 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4325
Imported an attachment (id=2011)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was alex.arnaud@biblibre.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, gmcharlt@gmail.com.
   Previous assignee was alex.arnaud@biblibre.com.
CC member jeanandre.santoni@biblibre.com does not have an account here
The original submitter of attachment 2011 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Alex Arnaud 2012-06-10 11:31:59 UTC
This bug/patch is not relevant anymore with the new staff design.