Bug 4334 - Notices Samples doesn't exist anymore
Summary: Notices Samples doesn't exist anymore
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: unspecified
Hardware: PC All
: PATCH-Sent (DO NOT USE) blocker (vote)
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-23 03:40 UTC by Nahuel Angelinetti
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch for bug 4334 (17.29 KB, patch)
2010-04-06 16:27 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:25:57 UTC


---- Reported by nahuel.angelinetti@biblibre.com 2010-03-23 15:40:01 ----

it seems sample_notices.sql doesn't exist anymore, in french and english.
And there is some option files that are not in french, but that MUST be in every language like : 
installer/data/mysql/fr-FR/2-Optionel/sample_notices_message_attributes.sql
installer/data/mysql/fr-FR/2-Optionel/sample_notices_message_transports.sql



---- Additional Comments From ian.walls@bywatersolutions.com 2010-04-06 16:14:19 ----

In HEAD, I've noticed that the English sample_notices are not loading, which also prevents sample_notices_message_attributes.sql and sample_notices_message_transports.sql from loading, since they are foreign-key dependent upon a populated sample notices table.

The problem is non-escaped double quotes inside the content for ODUE: 

VALUES ('circulation','ODUE','Overdue Notice','Item Overdue',"Dear <<borrowers.firstname>> <<borrowers.surname>>,\n\nAccording to our current records, you have items that are overdue.Your library does not charge late fines, but please return or renew them at the branch below as soon as possible.\n\n<<branches.branchname>>\n<<branches.branchaddress1>>\n<<branches.branchaddress2>> <<branches.branchaddress3>>\nPhone: <<branches.branchphone>>\nFax: <<branches.branchfax>>\nEmail: <<branches.branchemail>>\n\nIf you have registered a password with the library, and you have a renewal available, you may renew online. If an item becomes more than 30 days overdue, you will be unable to use your library card until the item is returned.\n\nThe following item(s) is/are currently overdue:\n\n<item>"<<biblio.title>>" by <<biblio.author>>, <<items.itemcallnumber>>, Barcode: <<items.barcode>> Fine: <fine>GBP</fine></item>\n\nThank-you for your prompt attention to this matter.\n\n<<branches.branchname>> Staff\n"),

This seems applicable to other languages, as well (except French).



---- Additional Comments From ian.walls@bywatersolutions.com 2010-04-06 16:27:47 ----

Created an attachment
Patch for http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4334

Fixes double quotes problem in all languages but french.

Note that since one line is longer than 998, won't send as git send-email



---- Additional Comments From gmcharlt@gmail.com 2010-04-30 03:21:09 ----

Please submit patch as attachment.



---- Additional Comments From gmcharlt@gmail.com 2010-04-30 12:37:06 ----

Patch pushed.  Please test and close.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:25 UTC  ---

This bug was previously known as _bug_ 4334 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4334
Imported an attachment (id=2023)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 2023 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Chris Cormack 2010-05-22 08:24:12 UTC
Tested and confirmed that I can no load the sample notices, in both french and english