Bug 4377 - cannot confirm hold due to missing letter
Summary: cannot confirm hold due to missing letter
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: PC All
: P5 - low blocker (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL: cgi-bin/koha/circ/returns.pl
Keywords:
Depends on:
Blocks: 4466
  Show dependency treegraph
 
Reported: 2010-04-08 12:29 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patch file against current head (9.72 KB, patch)
2010-04-13 17:51 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:26:26 UTC


---- Reported by nengard@gmail.com 2010-04-08 00:29:49 ----

When I attempted to confirm a hold on checkin I was presented with the following:


Could not find a letter called 'HOLD_PRINT' in the 'reserves' module at /home/nengard/kohaclone/C4/Reserves.pm line 1718.

For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. 



In my system  emailLibrarianWhenHoldIsPlaced   is set to enable. And    PrintNoticesMaxLines   is set to  0



---- Additional Comments From jwagner@ptfs.com 2010-04-12 11:47:55 ----

See http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3482 -- you need to create a separate HOLD_PRINT notice (formatted for printing) for print hold notices to work.




---- Additional Comments From nengard@gmail.com 2010-04-12 18:43:56 ----

There should be a default template for this if it's necessary to perform another function.  It should not be up to the users to know that they need to create a template for the missing notice.



---- Additional Comments From jwagner@ptfs.com 2010-04-13 17:51:00 ----

Created an attachment
patch file against current head

Patch sent April 13, 2010 -- please check the structure.  I haven't tried creating a notice file before.



---- Additional Comments From gmcharlt@gmail.com 2010-04-30 02:02:50 ----

Patch pushed.  Please test and close.



---- Additional Comments From nengard@gmail.com 2010-05-02 19:06:50 ----

Not sure how to test this since it only adds the template for new installs and I'd be upgrading.  Based on what I see I assume it will work.  This bug can be reopened if someone with a new installs finds differently. 



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:26 UTC  ---

This bug was previously known as _bug_ 4377 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4377
Imported an attachment (id=2055)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
CC member jwagner@ptfs.com does not have an account here
The original submitter of attachment 2055 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Galen Charlton 2010-05-25 16:29:26 UTC
Reopened - needs updatabase.pl change and correction of errors in install scripts.
Comment 2 Galen Charlton 2010-05-25 16:56:36 UTC
Pushed patch to insert the HOLD_PRINT template during upgrade (database revision 135).  Also fixed SQL errors that broken inserting the notice template during installation.  Please test and close.