Bug 4381 - systempreference hide_marc = ON results in erroneous behaviour of repeatable fields and subfields
Summary: systempreference hide_marc = ON results in erroneous behaviour of repeatable ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: PC All
: P3 major (vote)
Assignee: Fridolin Somers
QA Contact: Bugs List
URL:
Keywords:
Depends on: 7455
Blocks:
  Show dependency treegraph
 
Reported: 2010-04-08 10:14 UTC by Chris Cormack
Modified: 2013-12-05 20:01 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.92 KB, patch)
2012-09-27 08:26 UTC, Fridolin Somers
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:26:29 UTC


---- Reported by verolencinas@yahoo.com.ar 2010-04-08 22:14:38 ----

If you configure systempreference hide_marc = ON and you don't use thesaurus for authorities, repeatable fields are recorded as repeatable subfields. There is no way to fix this on the Web interface.
Koha version: 3.0005003.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:26 UTC  ---

This bug was previously known as _bug_ 4381 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4381

Unknown operating system Linux - Debian. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was verolencinas@yahoo.com.ar.
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Fridolin Somers 2012-09-27 08:26:54 UTC
Created attachment 12545 [details] [review]
Proposed patch

Simple patch.
Even with hide_marc, inficators are input in biblio and authorities cataloguing. They are just hidden type.
So cloning javascript method must always take care of indicators.
Comment 2 Fridolin Somers 2012-09-27 08:30:58 UTC
Test plan :
-----------

Set hide_marc syspref to 'don't display'.
Edit a bibio/authority record with a repeatable field.
  For example : 
  606
     a APPLE
  606
     a BANANA

Save the record.
In MARC you get : 
  606
     a APPLE
     a BANANA

With patch, record is well saved.
Comment 3 Jared Camins-Esakov 2012-10-21 14:52:56 UTC
I cannot duplicate this issue. Can you confirm that you are still seeing it in master?
Comment 4 Fridolin Somers 2012-10-24 08:48:53 UTC
(In reply to comment #3)
> I cannot duplicate this issue. Can you confirm that you are still seeing it
> in master?
Yes, it still exists on master.

The cause is that whith 'hide_marc', when cloning a field, the indicator inputs are cloned without any change. So the MARC editor thinks all subfields are in the same field.
Comment 5 Kyle M Hall 2012-11-02 14:45:39 UTC
I'm a bit confused. If

  606
     a APPLE
  606
     a BANANA

is what I'm supposed to get, this appears to be working in master.

Also, the patch no longer applies.
Comment 6 Fridolin Somers 2012-11-02 16:18:27 UTC
I reproduce the bug on actual master.

I rewrite test plan : 

- Set hide_marc syspref to "don't display"
=> in MARC editor, field and subfield codes are not displayed.

- Create a new bibio/authority record.

- On a repeatable field, write a data :
  606
     a APPLE

- Clone this field :
  606
     a APPLE
  606
     a APPLE

- Change the second field content : 
  606
     a APPLE
  606
     a BANANA

- Save the record.

- In MARC you get the two datas in one field : 
  606
     a APPLE
     a BANANA
Comment 7 Fridolin Somers 2012-11-02 16:29:42 UTC
Sorry, your totally right, bug was corrected by Bug 7455 (witch I made) : correction was integrated in cataloguing.js creation.