Bug 4386 - New print notice feature not obeying email address for hold notices
Summary: New print notice feature not obeying email address for hold notices
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: PC All
: P2 blocker (vote)
Assignee: Galen Charlton
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 03:35 UTC by Jane Wagner
Modified: 2019-06-27 09:24 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:26:33 UTC


---- Reported by jwagner@ptfs.com 2010-04-13 15:35:49 ----

See http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3482 and http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4377 -- the original feature we wrote in http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3482 only used the HOLD_PRINT notice file and the print notice feature if the patron did not have an email address.  BibLibre amplified the feature and submitted it, and it's now in head.  I'm not sure where the problem crept in, but now a hold notice for a patron with an email address is being routed to the HOLD_PRINT notice, not using the HOLD notice.

The problem does not exist with overdue notices; a patron with an email address gets an emailed notice.



---- Additional Comments From katrin.fischer@bsz-bw.de 2010-04-28 12:28:13 ----

This bug is still present in 3.01.00.127.

You currently can't send hold notices by email.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:26 UTC  ---

This bug was previously known as _bug_ 4386 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4386

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was jwagner@ptfs.com.
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Galen Charlton 2010-05-26 03:31:14 UTC
Pushed patch to fix this.  Please test and close.
Comment 2 Jane Wagner 2010-05-26 12:23:04 UTC
The fix seems to work properly -- I triggered holds for patron records with and without email addresses, and the appropriate notice was generated for both.