Bug 4415 - child record only using parent's info
Summary: child record only using parent's info
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: PC All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Srdjan Jankovic
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-27 07:42 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
patron add/edit form (18.69 KB, image/png)
2010-08-23 19:35 UTC, Nicole C. Engard
Details
address right on search (11.37 KB, image/png)
2010-08-23 19:35 UTC, Nicole C. Engard
Details
address wrong on patron detail (28.05 KB, image/png)
2010-08-23 19:36 UTC, Nicole C. Engard
Details
patch (3.26 KB, patch)
2011-07-20 07:24 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
patch (4.01 KB, patch)
2011-07-21 23:51 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
parent (135.10 KB, image/png)
2011-07-22 18:03 UTC, Nicole C. Engard
Details
child (116.96 KB, image/png)
2011-07-22 18:03 UTC, Nicole C. Engard
Details
patch (5.94 KB, patch)
2011-07-27 04:39 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
proposed patch (passed QA) (6.05 KB, patch)
2011-08-03 10:08 UTC, Paul Poulain
Details | Diff | Splinter Review
bug_4415: Copy parent contact details to child when adding Let child details be managed separately (6.10 KB, patch)
2011-08-03 10:20 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:26:54 UTC


---- Reported by nengard@gmail.com 2010-04-27 19:42:30 ----

When i created a child record I entered in a phone number for the patron and no email.  When I looked at the patron in record in the staff client I see that it brought over the parent email and phone and ignored the phone I entered for the child.

None of this showed on the entry form - just after I saved the patron.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:26 UTC  ---

This bug was previously known as _bug_ 4415 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4415

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Ian Walls 2010-07-13 20:32:58 UTC
Proposed workflow for a fix:

Enhance guarantorsearch.pl to have a second stage, wherein the librarian, upon finding the guarantor, can select which contact information to bring over and into which set of fields (regular, B_* or alt*).  These values are then automatically filled into the form for the child account, and can be edited before being saved.

This would not include automatic synchronization, wherein the child's contact info is updated when the parent's changes.  This would be an enhancement for later.
Comment 2 Nicole C. Engard 2010-07-14 00:22:21 UTC
That works, I'd also be happy if it filled the form in like it does now but lets me edit - the letting me edit part is all that matters.
Comment 3 Nicole C. Engard 2010-08-23 19:35:43 UTC
Created attachment 2560 [details]
patron add/edit form

I have found out more about this bug.  It looks like I can edit the address for the child and the data does save, but it's not what prints to the screen when you view patron details.  See this and other screenshots
Comment 4 Nicole C. Engard 2010-08-23 19:35:59 UTC
Created attachment 2561 [details]
address right on search
Comment 5 Nicole C. Engard 2010-08-23 19:36:16 UTC
Created attachment 2562 [details]
address wrong on patron detail
Comment 6 Nicole C. Engard 2010-08-23 21:11:36 UTC
Related to this bug (i think):

when adding a child record the phone and email from the parent isn’t coming over into the form, but it is on the patron record when you save - this should be in the form and should be editable
Comment 7 Srdjan Jankovic 2010-09-30 04:19:38 UTC
Assigned to Srdjan
Comment 8 Liz Rea 2011-05-31 19:43:38 UTC
I think we just need to display the changed child data, either in place of, or in addition to, the guarantor's data.
Comment 9 Srdjan Jankovic 2011-07-20 07:24:20 UTC Comment hidden (obsolete)
Comment 10 Nicole C. Engard 2011-07-20 12:32:27 UTC
I just tested this by clicking 'add child' on an adult record.  I changed the HOME phone and when I clicked save my changes were not saved, instead it showed the adult's info still, not the info I put in the record.

It did add the new email I put in and it changed the address like I wanted - just the phone was not fixed.

Nicole
Comment 11 Liz Rea 2011-07-20 15:08:42 UTC
NEKLS is sponsoring a fix for this as well, please make sure you coordinate with ByWater on future fixes.
Comment 12 Liz Rea 2011-07-20 17:58:14 UTC
hehe, nevermind, sorry Srdjan. You're on our team!

:)
Comment 13 Srdjan Jankovic 2011-07-21 01:10:30 UTC
I just checked it and it worked for me. how can we make sure that the patch was applied?
Comment 14 Nicole C. Engard 2011-07-21 02:24:04 UTC
This does not work for me - please see this video as I apply the patch, add a child and change the child's phone number. My changes are not saved - the number I enter is 1213 and it keeps the 1212 from her 'parent'

http://screencast.com/t/ELF5Nuy5ppj
Comment 15 Chris Cormack 2011-07-21 02:43:24 UTC
It is changing, the change is made in the db

BUT on the moremember.pl page, it is not showing the phone number from the childs record, but is showing the guarantors.
Comment 16 Nicole C. Engard 2011-07-21 12:22:41 UTC
Well that explains it - we need to actually see the right phone number (and all other right details) on the screen.

Nicole
Comment 17 Liz Rea 2011-07-21 14:27:37 UTC
Agreed with Nicole -- seeing the changes on moremember.pl is a necessary part of this development and what was intended.
Comment 18 Srdjan Jankovic 2011-07-21 23:51:36 UTC Comment hidden (obsolete)
Comment 19 Nicole C. Engard 2011-07-22 01:12:35 UTC
Okay,

One more problem. It now shows the right primary phone based on the edits I make, but the parent's number under alternate contacts is also changed now - and it is the one that should stay set the way it was originally.

Also, I didn't know that the alternate contact would be there because that data wasn't in the form when I was filling it out - and it's not there when I go to edit the child.  All data that is in the DB should show on the entry form and on the detail screen for the patron so that you can edit any of it when you want.

No decisions should be made by Koha and be left unable to edit (when it comes to patrons).

Nicole
Comment 20 Chris Cormack 2011-07-22 03:43:04 UTC
By alternate contact ... do you mean alternate address nicole?
Comment 21 Nicole C. Engard 2011-07-22 18:02:10 UTC
Chris,

Yes I did :)
Comment 22 Nicole C. Engard 2011-07-22 18:03:11 UTC
Created attachment 4721 [details]
parent

Note on the parent record that the 'alternate address' shows address fields on the right.
Comment 23 Nicole C. Engard 2011-07-22 18:03:49 UTC
Created attachment 4722 [details]
child

note on the child record that the alternate address area is showing the same fields as alternate contact - and not the fields that were there on the adult record.  Why the difference?
Comment 24 Srdjan Jankovic 2011-07-27 04:39:45 UTC Comment hidden (obsolete)
Comment 25 Paul Poulain 2011-08-03 10:08:20 UTC Comment hidden (obsolete)
Comment 26 Chris Cormack 2011-08-03 10:20:42 UTC
Created attachment 4817 [details] [review]
bug_4415: Copy parent contact details to child when adding Let child details be managed separately

Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 27 Chris Cormack 2011-08-03 10:23:17 UTC
Pushed to master, please test
Comment 28 Liz Rea 2011-08-16 14:22:40 UTC
Tested, works!

Thanks!