---- Reported by nengard@gmail.com 2010-04-27 19:42:30 ---- When i created a child record I entered in a phone number for the patron and no email. When I looked at the patron in record in the staff client I see that it brought over the parent email and phone and ignored the phone I entered for the child. None of this showed on the entry form - just after I saved the patron. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:26 UTC --- This bug was previously known as _bug_ 4415 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4415 Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Proposed workflow for a fix: Enhance guarantorsearch.pl to have a second stage, wherein the librarian, upon finding the guarantor, can select which contact information to bring over and into which set of fields (regular, B_* or alt*). These values are then automatically filled into the form for the child account, and can be edited before being saved. This would not include automatic synchronization, wherein the child's contact info is updated when the parent's changes. This would be an enhancement for later.
That works, I'd also be happy if it filled the form in like it does now but lets me edit - the letting me edit part is all that matters.
Created attachment 2560 [details] patron add/edit form I have found out more about this bug. It looks like I can edit the address for the child and the data does save, but it's not what prints to the screen when you view patron details. See this and other screenshots
Created attachment 2561 [details] address right on search
Created attachment 2562 [details] address wrong on patron detail
Related to this bug (i think): when adding a child record the phone and email from the parent isn’t coming over into the form, but it is on the patron record when you save - this should be in the form and should be editable
Assigned to Srdjan
I think we just need to display the changed child data, either in place of, or in addition to, the guarantor's data.
Created attachment 4672 [details] [review] patch
I just tested this by clicking 'add child' on an adult record. I changed the HOME phone and when I clicked save my changes were not saved, instead it showed the adult's info still, not the info I put in the record. It did add the new email I put in and it changed the address like I wanted - just the phone was not fixed. Nicole
NEKLS is sponsoring a fix for this as well, please make sure you coordinate with ByWater on future fixes.
hehe, nevermind, sorry Srdjan. You're on our team! :)
I just checked it and it worked for me. how can we make sure that the patch was applied?
This does not work for me - please see this video as I apply the patch, add a child and change the child's phone number. My changes are not saved - the number I enter is 1213 and it keeps the 1212 from her 'parent' http://screencast.com/t/ELF5Nuy5ppj
It is changing, the change is made in the db BUT on the moremember.pl page, it is not showing the phone number from the childs record, but is showing the guarantors.
Well that explains it - we need to actually see the right phone number (and all other right details) on the screen. Nicole
Agreed with Nicole -- seeing the changes on moremember.pl is a necessary part of this development and what was intended.
Created attachment 4704 [details] [review] patch
Okay, One more problem. It now shows the right primary phone based on the edits I make, but the parent's number under alternate contacts is also changed now - and it is the one that should stay set the way it was originally. Also, I didn't know that the alternate contact would be there because that data wasn't in the form when I was filling it out - and it's not there when I go to edit the child. All data that is in the DB should show on the entry form and on the detail screen for the patron so that you can edit any of it when you want. No decisions should be made by Koha and be left unable to edit (when it comes to patrons). Nicole
By alternate contact ... do you mean alternate address nicole?
Chris, Yes I did :)
Created attachment 4721 [details] parent Note on the parent record that the 'alternate address' shows address fields on the right.
Created attachment 4722 [details] child note on the child record that the alternate address area is showing the same fields as alternate contact - and not the fields that were there on the adult record. Why the difference?
Created attachment 4750 [details] [review] patch Took out child logic from the template
Created attachment 4816 [details] [review] proposed patch (passed QA) Nicole has signed-off the bug, but forgot to upload the signed-off patch. I've added her in my own signed-off again patch Nothing to note from a QA point of view, it's a simple patch, and works as advertised, although there's many comments, the one who helped me to understand is the comment 14 (forget comment 1, it was an initial suggestion from Ian, not done this way)
Created attachment 4817 [details] [review] bug_4415: Copy parent contact details to child when adding Let child details be managed separately Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Pushed to master, please test
Tested, works! Thanks!