Bug 4423 - Staff Client XSLT is just a copy of the OPAC one
Summary: Staff Client XSLT is just a copy of the OPAC one
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) major
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 2771
  Show dependency tree / graph
 
Reported: 2010-04-29 12:31 UTC by Nicole C. Engard
Modified: 2010-11-30 15:54 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Partial fix (2.48 KB, patch)
2010-05-28 18:51 UTC, Owen Leonard 		Details | Diff | Splinter Review
Some fixes (17.11 KB, patch)
2010-06-02 19:18 UTC, Owen Leonard 		Details | Diff | Splinter Review
Additional change (2.95 KB, patch)
2010-08-04 20:16 UTC, Owen Leonard 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:27:00 UTC 


---- Reported by nengard@gmail.com 2010-04-29 12:31:19 ----

The XSLT template for the staff client is just a copy of the one for the OPAC and need to be re-written. It's missing things like the 'view in opac' link and the 'lists this title is in' section.  Also, it's not styled for the staff client in the least and so it looks kind of sloppy.  Finally all the links are broken because they point to the OPAC - which was patched by someone else - but that was just one thing in a much bigger issue so I mention it here as well.



---- Additional Comments From nengard@gmail.com 2010-04-29 12:34:15 ----

That patch was to http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4285 by Garry Collum.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4423 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4423

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Comment 1 Owen Leonard 2010-05-28 18:51:37 UTC 
Created attachment 2187 [details] [review]
Partial fix

Partial fix for Bug 4423, Staff Client XSLT is just a copy of the OPAC one

This patch improves the template logic specifying a layout based on whether the display is XSLT or normal, and whether Amazon Content is on or off. Previously XSLT view did not display Amazon covers when enabled.
Comment 2 Owen Leonard 2010-06-02 19:18:47 UTC 
Created attachment 2203 [details] [review]
Some fixes

More fixes for Bug 4423, Staff Client XSLT is just a copy of the OPAC one
    
    - Adding material type icons from the OPAC side
    - Adding OPAC View link
    - Copying revised handling of MU from the OPAC
    - Removing OPAC-specific markup
Comment 3 Nicole C. Engard 2010-06-02 22:19:49 UTC 
Owen you are awesome! One thing I didn't mention - it's also missing the list of lists this item is in.
Comment 4 Galen Charlton 2010-06-24 02:53:35 UTC 
Patches pushed.  Please test.
Comment 5 Nicole C. Engard 2010-06-24 23:34:11 UTC 
With the exception of the missing links to lists this title is in it looks much better.
Comment 6 Owen Leonard 2010-08-04 20:16:59 UTC 
Created attachment 2466 [details] [review]
Additional change

     - Adding "Lists that include this title" links
     - Also correcting minor XHTML error in the same section of opac-detail.tmpl
Comment 7 Chris Nighswonger 2010-11-18 03:15:32 UTC 
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 8 Chris Nighswonger 2010-11-30 15:54:47 UTC 
A fix for this bug has been committed to the current development HEAD as well as released in 3.2.1.