Bug 4449 - Cannot place holds on unchecked-out missing items if AllowShelfHolds turned off
Summary: Cannot place holds on unchecked-out missing items if AllowShelfHolds turned off
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: PC All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Ian Walls
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-04 07:48 UTC by Ian Walls
Modified: 2013-12-05 20:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
patch - signed off (1.86 KB, patch)
2010-09-09 20:48 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:27:19 UTC


---- Reported by ian.walls@bywatersolutions.com 2010-05-04 19:48:05 ----

If an item is marked as missing, and AllowShelfHolds is turned off, a library must check out all these items to a dummy patron in order for them to be reservable.  This is not always desirable behaviour.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4449 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4449

Unknown operating system Windows 2000. Setting to default OS "All".
Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Nicole C. Engard 2010-09-09 20:48:36 UTC
Created attachment 2617 [details] [review]
patch - signed off
Comment 2 Chris Cormack 2010-12-01 19:39:16 UTC
Patch pushed to master please test
Comment 3 MJ Ray (software.coop) 2010-12-08 10:15:34 UTC
This bug is mentioned in:
Bug 4449:	AllowHoldPolicyOverride does not override all hold policies http://lists.koha-community.org/pipermail/koha-patches/2010-November/013133.html
Comment 4 Nicole C. Engard 2010-12-16 14:27:52 UTC
This worked when I signed off on it, but I'm not seeing this functionality working on HEAD right now.  Can someone else test?
Comment 5 Owen Leonard 2011-02-14 20:47:09 UTC
This isn't working for me either. Tested in the OPAC on a record where all the items were LOST: Couldn't place a hold. After checking one of the items out the option to place a hold became available.

Also: the attached patch doesn't look like it is relevant to this problem.
Comment 6 Paul Poulain 2011-04-08 15:19:20 UTC
I confirm this patch has not been applied on master. Switching back to "signed-off" (although i've not tested it still applied).
Comment 7 Chris Cormack 2011-04-08 23:41:31 UTC
A patch for 4449 was pushed
5e8b078651624cee7bc4f86e206cf36c8ace9c4d

This was the one sent to the mailing list, will apply the one attached now.
Comment 8 Jared Camins-Esakov 2012-12-31 00:03:04 UTC
There have been no further reports of problems so I am marking this bug resolved.