Bug 4454 - Store Expirydate In Subscription
Summary: Store Expirydate In Subscription
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: Main
Hardware: PC All
: P5 - low enhancement (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-05 04:57 UTC by Colin Campbell
Modified: 2021-12-13 21:10 UTC (History)
1 user (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:27:23 UTC


---- Reported by colin.campbell@ptfs-europe.com 2010-05-05 16:57:31 ----

At present expirydate is calculated when needed for a subscription. As a result it is not available for e.g. sql reports. As this means that the site cannot get a count of active subscriptions (definition being that they have not yet expired) basic management info cannot be retrieved.
Storing the the expirydate will also allow some improvement in the efficiency of the serials code as in order to get the field the code currently reexecutes the fetch of subscription data just executed.

Testing has shown some anomalies in the existing expiry date code. (calculations for 32 two-weekly issues are giving a date far too soon). 

Code should ensure that expiry date is set correctly after add and modify operations on subscription

Work is sponsered by the library of FAO, United Nations



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4454 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4454

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Colin Campbell 2010-07-21 09:53:30 UTC
enddate field was added in 3.2 but field is not being set or read. Will use this field. Timeframe for 3.4 as it takes advantage of refactoring of Serials.pm for more reliability
Comment 2 Katrin Fischer 2013-04-13 19:52:50 UTC
Subscription end date is part of the subscription now, but not mandatory. Not sure if this bug can be closed?
Comment 3 Katrin Fischer 2021-04-12 09:29:37 UTC
I believe this can be closed as the field is exsiting and used now. Please reopen if I am mistaken.