---- Reported by oleonard@myacpl.org 2010-05-10 12:56:42 ---- I would like to see a way for OPAC users to see a list of recent comments in the OPAC. This could be a separate page or just a section which could be enabled on the OPAC main page. It should also provide an RSS feed for recent comments. --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC --- This bug was previously known as _bug_ 4473 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4473 Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one.
Created attachment 2606 [details] Screenshot of proposed page display Here's a picture what I've worked up so far. I re-purposed the existing script opac-showreviews.pl which wasn't being used anywhere. The display follows the pattern of the non-XSLT results display with the addition of the comment. It shows the 20 most recent comments.
Pretty!
Created attachment 2608 [details] Screenshot of proposed rss display Here's an in-Firefox preview of the RSS feed of recent comments
Created attachment 2817 [details] [review] Proposed fix - modifies opac-showreviews.pl to display recent comments for all titles, sorted in descending order by date. - includes RSS feed - includes (thanks to Chris N.): [Enhancement][3.4] Add RFC822 Format to C4::Dates This patch adds RFC822 formatting to C4::Dates. It also updates Dates.t appropriately. Consult the POD for this module for how to use this format. Please note that this module *does not* handle TZ conversion at this point. This means that the TZ portion of a RFC822 time will be truncated and the converted time will be in the same TZ as was passed in. When generating an RFC822 time, the local TZ offset will be included since none of the other supported formats provide a means for including their TZ. This is not a problem introduced by the addition of RFC822 formatting. Rather it is due to this module not having TZ support to begin with. Also note that the dow, moy abbreviations are English as required by RFC822 section 3.3 (thanks to self for pointing that out).
Pushed to master please test
Where is this page? Is it something that the library can add a link to? Or is it already in Koha and I just can't figure out how to get to it?
> Where is this page? Is it something that the library can add a link to? There's no link to it anywhere yet, but you can find it at opac-showreviews.pl. I'm open to suggestions for link placement.
when i go to that page on my local install I get "Can't call method "field" on an undefined value at /home/nengard/kohaclone/C4/Koha.pm line 1265." The link could go across the top with the other links (tags, suggestions, etc)
Owen the template needs some work, its failing the translatability test as there are ifs nested inside the CDATA tags not ok 1 - opac templates are translatable # Failed test 'opac templates are translatable' # at xt/author/translatable-templates.t line 49. # xgettext.pl: Warning: opac-showreviews-rss.tmpl: line 14: Possible SGML "closed start tag" notation: <![CDATA[ # # <!-- TMPL_IF NAME="OPACAmazonEnabled" --><!-- TMPL_IF NAME="OPACAmazonCoverImages" --><!-- TMPL_IF NAME="normalized_isbn" -->< Its not breaking anything some I'm happy to leave it in, but a follow up patch to fix the template for translators will be needed before release or it will have to come out
Have edited the TmplTokenizer file so that this stops erroring. With the rewrite to template::toolkit this will become a non-issue but for now it stops hudson whining at me :)
This bug is mentioned in: Fix for Bug 4473 - Recent comments view for the OPAC http://lists.koha-community.org/pipermail/koha-patches/2010-December/013197.html Fix for Bug 4473 - Recent comments view for the OPAC http://lists.koha-community.org/pipermail/koha-patches/2010-December/013216.html
Created attachment 5692 [details] [review] Follow-up fix This follow-up adds a system preference which controls display of a link to recent comments in the OPAC masthead alongside "Advanced search," "Tag cloud," etc.
Created attachment 5696 [details] [review] [SIGNED-OFF] Follow-up fix for Bug 4473 - Recent comments view for the OPAC This follow-up adds a system preference which controls display of a link to recent comments in the OPAC masthead alongside "Advanced search," "Tag cloud," etc. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
QA comment: Do we really need a syspref for this ? If showreview is unreachable without the link, I think it's enough to say "if the reviews are enabled, then the link is enabled too"
I think we need it to be consistent. All other links up there are controlled with preferences and I guess libraries like to decide what shows on their menus. Nicole
Remaining followup patch is just the necessary system preference and template changes to make this feature usable. From the screenshots, this looks like a very good feature, and adding the links to it will make it much more usable. Marking as Passed QA
Pushed, please test