---- Reported by katrin.fischer@bsz-bw.de 2010-05-12 22:26:12 ---- Created an attachment screenshot In navigation of acquisitions there is always a link with '1 suggestions waiting' even when table suggestions is empty. Both '1 suggestions waiting' and 'Manage suggestions' link to suggestions.pl. ---- Additional Comments From gcollum@gmail.com 2010-05-18 21:18:33 ---- It looks like <!-- TMPL_IF name="suggestion" --> in acquisitions-menu.inc is pulling its value from a global variable defined in Auth.pm - suggestion => C4::Context->preference("suggestion"). If patron suggestions are turned on you get a message indicating that there is one suggestion pending, if not you get a message that indicates that there are no messages. This could easily be fixed by changing the variable name to something like 'pendingsuggestions' and using the CountSuggestion function in Suggestions.pm to acquire a value, but does this code need to be in every .pl file whose template will include acquisitions-menu.inc, or can it be defined as a global module variable in either Suggestions.pm, or Acquisitions.pm? --- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC --- This bug was previously known as _bug_ 4498 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4498 Imported an attachment (id=2131) Actual time not defined. Setting to 0.0 Setting qa contact to the default for this product. This bug either had no qa contact or an invalid one. The original submitter of attachment 2131 [details] is unknown. Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
*** Bug 4825 has been marked as a duplicate of this bug. ***
Created attachment 2573 [details] [review] Proposed fix - Removing 'suggestions waiting' link from left-hand menu. A plain 'suggestions' link is still shown if suggestions are enabled. - Putting back the 'pending suggestions' box that used to appear on the Acquisitions home page. This will show, with a count of pending suggestions, only if suggestions are turned on and there are pending suggestions.
Tested successfully with current 3.01.00.145, signed off and resend to list. Sys pref suggestion ON/OFF Added new suggestion, recected and accepted suggestions
Patch still applies to HEAD.
Successfully tested on current master.
This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Tested ok in 3.2.1