Bug 4500 - Cant edit budget because of currency formatting
Summary: Cant edit budget because of currency formatting
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Robin Sheat
QA Contact: Bugs List
URL:
Keywords:
: 5091 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-05-13 08:31 UTC by Katrin Fischer
Modified: 2012-10-25 22:52 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
screenshot (14.70 KB, image/png)
2010-07-13 08:23 UTC, Katrin Fischer 		Details
proposed patch (739 bytes, patch)
2010-08-09 05:25 UTC, Robin Sheat 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:27:55 UTC 


---- Reported by katrin.fischer@bsz-bw.de 2010-05-13 20:31:06 ----

When editing a budget currency is formatted to show as '10,000.00'.

The formatting prevents the form from saving - changing the format to 10000 manually can cause errors, for example if you forget to delete the .00 at the end.

/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form&budget_period_id=1

Tested with Koha 3.01.00.134



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:27 UTC  ---

This bug was previously known as _bug_ 4500 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4500

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
Comment 1 Katrin Fischer 2010-07-13 08:23:50 UTC 
Created attachment 2350 [details]
screenshot

Problem still exists in Koha Version 3.01.00.142.

Added screenshot to show problem with currency formatting.
Comment 2 Katrin Fischer 2010-08-05 05:02:41 UTC 
*** Bug 5091 has been marked as a duplicate of this bug. ***
Comment 3 Robin Sheat 2010-08-09 05:25:51 UTC 
Created attachment 2487 [details] [review]
proposed patch

This appears to be a locale-related thing, that showed up when running the webserver in an nl_NL environment, but not en_NZ. Probably why Katrin found it in a (I assume) de_DE locale, or similar.

This patch should override the relevant locale-derived formatting.
Comment 4 Katrin Fischer 2010-08-09 05:45:18 UTC 
I successfully tested Robin's patch on a current installation from HEAD (3.01.00.145). 

The amount is now correctly shown as 10000.00 and the form can be saved without any changes.
Comment 5 Katrin Fischer 2010-12-06 15:58:04 UTC 
Robin's patch still applies and solves the problem. 
Signed-off and resent to list.
Comment 6 Chris Cormack 2010-12-12 07:17:43 UTC 
Pushed, please test
Comment 7 Katrin Fischer 2010-12-12 11:20:49 UTC 
Successfully tested on current HEAD.