Bug 4513 - Resetting framework to Default seems impossible
Summary: Resetting framework to Default seems impossible
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 11:28 UTC by Marcel de Rooy
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (1.67 KB, patch)
2011-05-16 12:49 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:28:03 UTC


---- Reported by m.de.rooy@rijksmuseum.nl 2010-05-17 11:28:24 ----

If you have a record on another framework, clicking on framework Default does not work. The editor jumps back to the previous framework.

Two small adjustments in addbiblio.pl and associated template addbiblio.tmpl resolve the problem. See patch sent.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:28 UTC  ---

This bug was previously known as _bug_ 4513 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4513

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Katrin Fischer 2010-07-28 12:34:59 UTC
I run into this problem in my dev installation today. The problem did only exist with German templates, after I recreated them the problem was gone.

I think some recent change must have fixed this problem.

Closing bug.

--
Link to Marcel de Rooy's patch (just in case bug reappears)
http://lists.koha-community.org/pipermail/koha-patches/2010-May/011855.html
Comment 2 Marcel de Rooy 2010-07-28 12:51:53 UTC
(In reply to comment #1)
> I run into this problem in my dev installation today. The problem did only
> exist with German templates, after I recreated them the problem was gone.
> I think some recent change must have fixed this problem.
> Closing bug.
> --
> Link to Marcel de Rooy's patch (just in case bug reappears)
> http://lists.koha-community.org/pipermail/koha-patches/2010-May/011855.html

Please note: Status is resolved/fixed. Patch has been incorporated in Koha 3.0.x with commit cf292b6ae3c41ce348e8beb27964d9ef943f6731.
Comment 3 Marcel de Rooy 2011-05-16 12:46:47 UTC
This problem is still or again? present in master.
Sending a revised patch.

Test this patch by opening a biblio saved in e.g. books framework.
Change the framework in Staff Cataloging back to Default and save.
Open the biblio again and check if it really has been set to Default.
Comment 4 Marcel de Rooy 2011-05-16 12:49:43 UTC Comment hidden (obsolete)
Comment 5 Nicole C. Engard 2011-05-18 13:32:43 UTC
Patch applies, but doesn't work as expected.

I opened a record and changed it from default to 'books' and saved. I then opened it again and changed from 'books' to 'default' and saved. I then opened it again to find that it still had 'books' as the framework.
Comment 6 Marcel de Rooy 2011-05-18 19:16:47 UTC
(In reply to comment #5)
> Patch applies, but doesn't work as expected.
> 
> I opened a record and changed it from default to 'books' and saved. I then
> opened it again and changed from 'books' to 'default' and saved. I then opened
> it again to find that it still had 'books' as the framework.

Oops, that doesn't sound good. I tested it and it seemed to work with the following note:
When you reopened the record and changed the framework to books, did you wait long enough for the server to respond and did you click Save when the page was reloaded? I stumbled over this, when I changed framework and immediately clicked Save.
Comment 7 Marcel de Rooy 2011-05-19 07:38:16 UTC
Resetting the status of this patch to Needs signoff.
It works when following comment6. That you should wait for the reloaded page, is not the issue of this bug.
Comment 8 Marcel de Rooy 2011-05-19 09:40:11 UTC
Bug cannot be reproduced anymore in 3.5 (only in 3.3).
Adjusted addbiblio.pl line
  $frameworkcode = &GetFrameworkCode($biblionumber)
  if ( $biblionumber and not($frameworkcode) and $op ne 'addbiblio' );
seems to resolve it.
See also bug 6067.