Bug 4515 - Few very small errors in opac-search.pl
Summary: Few very small errors in opac-search.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-17 12:00 UTC by Marcel de Rooy
Modified: 2010-11-18 07:43 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:28:05 UTC


---- Reported by m.de.rooy@rijksmuseum.nl 2010-05-17 12:00:36 ----

1 Additional check on existence of $query_cgi object
2 Loop on results should stop before $i==@servers
3 Variable content_type declared twice

Patch sent.



--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:28 UTC  ---

This bug was previously known as _bug_ 4515 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4515

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.

Comment 1 Marcel de Rooy 2010-11-04 11:32:20 UTC
Drop points 1 and 3 for master now. Point 2 still holds.
Adding fix for warnings on undefined values in comparison for lines 485, 488 and 510.

Corrected these small errors in patch for master now.

-for (my $i=0;$i<=@servers;$i++) {
+for (my $i=0;$i<@servers;$i++) {

-           if ($borrowernumber eq '') {
+           if (!$borrowernumber || $borrowernumber eq '') {

-               if ($params->{'offset'} eq '') {
+               if (($params->{'offset'}||'') eq '') {

-                       if ($params->{'offset'} eq '') {
+                       if (($params->{'offset'}||'') eq '') {
Comment 2 Chris Cormack 2010-11-08 07:04:28 UTC
Patch pushed, please test and close
Comment 3 Chris Nighswonger 2010-11-18 03:15:14 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.