Bug 4523 - aqbudgets.pl - possibility to show / hide the filters menu
Summary: aqbudgets.pl - possibility to show / hide the filters menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.4
Hardware: PC All
: P5 - low enhancement (vote)
Assignee: Chris Cormack
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-18 11:52 UTC by Chris Cormack
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
possibility to show / hide the filters menu (2.27 KB, patch)
2010-05-18 11:54 UTC, Chris Cormack
Details | Diff | Splinter Review
[replace previous] bug 4523 possibility to show hide the filters menu (1.59 KB, patch)
2010-05-18 14:26 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:28:10 UTC


---- Reported by alex.arnaud@biblibre.com 2010-05-18 11:52:10 ----

 



---- Additional Comments From alex.arnaud@biblibre.com 2010-05-18 11:54:36 ----

Created an attachment
possibility to show / hide the filters menu





---- Additional Comments From alex.arnaud@biblibre.com 2010-05-18 14:26:07 ----

Created an attachment
[replace previous] http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4523 possibility to show hide the filters menu





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:28 UTC  ---

This bug was previously known as _bug_ 4523 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4523
Imported an attachment (id=2139)
Imported an attachment (id=2140)

Actual time not defined. Setting to 0.0
The original reporter of this bug does not have
   an account here. Reassigning to the person who moved
   it here: chris@bigballofwax.co.nz.
   Previous reporter was alex.arnaud@biblibre.com.
The original assignee of this bug does not have
   an account here. Reassigning to the default assignee
   for the component, chris@bigballofwax.co.nz.
   Previous assignee was alex.arnaud@biblibre.com.
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 2139 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 2140 [details] [review] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Galen Charlton 2010-05-25 18:23:54 UTC
Marking as enhancement.  This patch needs review; while it works well enough, the notion of adding a show/hide filter link that has no equivalent in any other staff interface page seems to me to make the UI unnecessarily inconsistent.
Comment 2 Owen Leonard 2010-05-26 12:56:53 UTC
I agree with Galen. This looks like a useful feature, but I think it would be a good idea for us to spend some time thinking about a global method and style for this kind of interaction. We've already established a pattern for sidebar filters, we should to the same for this kind of interaction as well.
Comment 3 Galen Charlton 2010-06-25 00:38:12 UTC
Pushed patch to new/bug4523 topic branch for consideration in 3.4; as previous comments imply, however, if this is to be done, it ought to be done consistent, not just for a single page.
Comment 4 Paul Poulain 2012-02-17 14:39:06 UTC
The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply".

The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix.

If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script.
If the patch applies does not apply as I think, please rebase and resubmit, thanks
Comment 5 Chris Cormack 2013-01-01 23:03:26 UTC
Needs a new patch, written for template toolkit
Comment 6 Owen Leonard 2014-04-25 19:54:08 UTC
Not sure why this isn't marked as having been pushed to master. It appears to have been in Koha since 2010.