When using for search a direct CCL query (ie "q=su:action"), by editing URL or using some links (ie the link to subject in normal view of opac-details.pl). In this case, facets links are like (ie for branches) : "opac-search.pl?q=ccl=su:action&limit=branch:BR". This search doesn't limit the number of results : facet doesn't work. I think it comes from lib/C4/Search.pm. Version 3.2 alpha 2.
Steps to reproduce in the OPAC: 1) Do a CCL query. This is searching on a particular field, e.g. subject, but not using the dropdown. Either have the search term be 'su:Subject' or click on a subject (or author, or...) in a record. 2) Click on a facet on the left in order to refine the search 3) Note that the search isn't refined. The query in the URL that doesn't work ends with: ?q=ccl=au:Michael Fullan&limit=au:Mascall, Blair. A version of this that would work: ?q=ccl=au:Michael Fullan and au:Mascall, Blair.
Created attachment 2519 [details] [review] proposed patch This patch is intended for anyone interested in testing it. Once it's gone through our QA, I'll submit it to the list and switch the status on this bug.
Wheres this at now Robin?
Patch tested, It works fine. Workflow : Click on a link in details view (ie "au:La Fontaine"). You will see that facets are a ccl search with limits. Click on facets, it works.
Fridolyn, excellent thanks for the test. Are you up for trying to sign off the patch? http://wiki.koha-community.org/wiki/Sign_off_on_patches
(In reply to comment #5) > Fridolyn, excellent thanks for the test. > > Are you up for trying to sign off the patch? > > http://wiki.koha-community.org/wiki/Sign_off_on_patches Sorry, I'm a beginner with git. I've got to get familiar with it. I think I'll try another time. Regards,
If you can apply the patch, you're 95% of the way to being able to sign off on it :)
Created attachment 3217 [details] [review] Signed-off patch Applied and tested against current master.
Pushed, please test and mark resolved
This bug is mentioned in: Bug 4852 - rewrite the query to include limits if using ccl= http://lists.koha-community.org/pipermail/koha-patches/2011-February/013930.html Bug 4852 - rewrite the query to include limits if using ccl= http://lists.koha-community.org/pipermail/koha-patches/2011-February/013931.html