Bug 4853 - Rights needed to renew a document
Summary: Rights needed to renew a document
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Kyle M Hall
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-07 09:08 UTC by Nahuel Angelinetti
Modified: 2012-10-25 23:04 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (1.54 KB, patch)
2011-02-14 20:27 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nahuel Angelinetti 2010-06-07 09:08:34 UTC
At the moment, the rights needed to renew a document is "borrower", that have no sens... It should be "circulate".
Comment 1 Galen Charlton 2010-06-09 13:56:02 UTC
Patch pushed.  Please test and close.
Comment 2 Nicole C. Engard 2010-06-29 14:42:19 UTC
When a staff member has circulate permissions they cannot renew items.  Instead they are brought to: /cgi-bin/koha/reserve/renewscript.pl where they are asked to log in.

This happened with a staff member who had just circulate and catalogue permissions and when I tried with a staff member who had circulate, borrowers and catalogue permissions.
Comment 3 Owen Leonard 2010-07-07 16:57:52 UTC
What kind of renewal is blocked? What steps are necessary to duplicate the problem?
Comment 4 Owen Leonard 2010-07-07 16:59:23 UTC
Patch: http://lists.koha-community.org/pipermail/koha-patches/2010-June/012052.html. Patches were approved on 3.0.x and HEAD.
Comment 5 Chris Cormack 2010-12-13 03:30:49 UTC
This was pushed a while ago, please test and close
Comment 6 Nicole C. Engard 2010-12-16 15:55:58 UTC
I just tested on HEAD and the book does renew, but it brings you to a 'you don't have permission page' the only reason I know that it was actually renewed is because I tried to go back and test again only to find that the book was renewed.
Comment 7 Owen Leonard 2011-02-14 20:27:21 UTC
Created attachment 3152 [details] [review]
Proposed fix

Correcting check for circulation permission. Also updating
updateitem.pl (for setting lost and damaged statuses) with
circulate permissions.
Comment 8 MJ Ray (software.coop) 2011-03-03 08:37:02 UTC
This bug is mentioned in:
Fix for Bug 4853 - Rights needed to renew a	document http://lists.koha-community.org/pipermail/koha-patches/2011-February/013863.html
Comment 9 Chris Cormack 2011-03-05 19:28:31 UTC
Pushed, please test and mark resolved
Comment 10 MJ Ray (software.coop) 2011-04-06 13:52:21 UTC
This bug is mentioned in:
Fix for Bug 4853 - Rights needed to renew a	document http://lists.koha-community.org/pipermail/koha-patches/2011-March/013965.html