Bug 4857 - aqplan.pl: consideration of Planning categories with authorised values
Summary: aqplan.pl: consideration of Planning categories with authorised values
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: rel_3_2
Hardware: All All
: P5 - low critical
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 8224
  Show dependency treegraph
 
Reported: 2010-06-08 11:50 UTC by Alex Arnaud
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
aqplan.pl: consideration of Planning categories with authorised values (2.79 KB, patch)
2010-06-08 11:53 UTC, Alex Arnaud
Details | Diff | Splinter Review
aqplan.pl: consideration of Planning categories with authorised values (2.38 KB, patch)
2010-06-09 09:07 UTC, Alex Arnaud
Details | Diff | Splinter Review
Screenshot of incomplete menu (6.95 KB, image/gif)
2011-02-14 19:59 UTC, Owen Leonard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Arnaud 2010-06-08 11:50:12 UTC

    
Comment 1 Alex Arnaud 2010-06-08 11:53:01 UTC Comment hidden (obsolete)
Comment 2 Alex Arnaud 2010-06-09 09:07:18 UTC
Created attachment 2231 [details] [review]
aqplan.pl: consideration of Planning categories with authorised values
Comment 3 Galen Charlton 2010-06-25 00:52:07 UTC
Patch pushed.  Please test and close.
Comment 4 Chris Cormack 2010-12-13 01:27:05 UTC
This has been waiting since june, please test so we can close this
Comment 5 Owen Leonard 2011-02-14 19:59:44 UTC
Created attachment 3151 [details]
Screenshot of incomplete menu

Is this patch supposed to have added another entry to the "Plan by" options? Under some circumstances I see the empty "Plan by" entry as seen in this screenshot.
Comment 6 Paul Poulain 2011-02-22 13:14:32 UTC
owen, you can plan by month/branch/itemtype, but you're supposed to be able to plan by any of the authorised value category you're choosen when entering a fund in /cgi-bin/koha/admin/aqbudgets.pl?op=add_form&budget_period_id=1

if you get an empty one, it's probably because there's a bug : either you don't have choosen a planning category (in this case you should not have this line at all) or you've choosen a category in one fund, and you should have something.
Comment 7 Julian Maurice 2011-04-04 09:09:43 UTC
(In reply to comment #5) 
> Is this patch supposed to have added another entry to the "Plan by" options?
> Under some circumstances I see the empty "Plan by" entry as seen in this
> screenshot.

I confirm this.
Setting patch status to 'Failed QA'.
Comment 8 Katrin Fischer 2011-07-07 21:56:23 UTC
Some additional information about this:

http://localhost:8080/cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=3
Planning shows only itemtype, months and branches, no additional options.

After selection one of those 3 you go to another page with 2 pull downs. One in the toolbar on top and one in the filter on the left. Both worked for me most of the time. I haveseen the empty line other testers described once during my tests, but was not able to reproduce it, so I think this is still a problem but needs more testing.

There is also some weirdness after auto filling one form and saving it. - You get redirected to a different budget. In my case I had 3 active budgets for valid time periods. I was testing with the most recently added and was brought back to one of the older budgets after saving.
Comment 9 Alex Arnaud 2012-06-11 09:04:44 UTC
I created a new bug (bug 8224) for the remaining issues and sent a fix. So this one can be marked as resolved.