After editing a private list, the user is redirected back to the lists page but the tab on display is the one with public lists. The edit process should be made aware of which set of lists the users should be redirected to.
Created attachment 2274 [details] [review] Proposed fix
Pushed and merged, please test and close
This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
This is fixed if your path is: View private lists -> Click Edit button. It is still broken if your path is: Click list to view -> Click Edit button.
Created attachment 2773 [details] [review] Additional fixes
This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed.
A new patch has been sent for this, which is awaiting signoff (sent 18 November 2010)
This bug is mentioned in: Fix for Bug 4912 - After editing private list redirect to private lists http://lists.koha-community.org/pipermail/koha-patches/2010-November/012958.html Follow-up fix for Bug 4912, redirect user to correct lists http://lists.koha-community.org/pipermail/koha-patches/2010-November/013076.html
Is this still needed, I was going to apply and test for sign off, but I wanted to test the way it used to work first - and it's taking me to the right place.
(In reply to comment #9) > Is this still needed Yes, the additional fix is needed. To reproduce: 1. Click the "my lists" link in the OPAC 2. Click the title of one of your lists to view it. 3. Click the "edit list" link at the top of that view 4. Save your changes. You will be redirected to the "public lists" view.
Okay the additional fix works - but I got some errors when applying so I'm not sure if I should sign off: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Follow-up fix for Bug 4912, redirect user to correct lists Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-shelves.tmpl nengard@debian:~/kohaclone$
Additional fixes works for me too. I got the same warning but git merge success with the other way.
Pushed, please test
This seems to be broken again. After editing a list I'm redirected to a page which is blank except for a "new list" button.
Specifically, broken in the staff client.
Created attachment 7631 [details] [review] Bug 4912 - After editing private list, user should be redirect to private lists As far as I can tell there isn't a redirect in the code which is triggered in the wake of a ModShelf() action. This patch adds a redirect. To test, edit the details of a private and public list in the OPAC and staff client and confirm that you are redirected to a view of that list's contents after saving.
Created attachment 7646 [details] [review] [SIGNED-OFF] Bug 4912 - After editing private list, user should be redirect to private lists As far as I can tell there isn't a redirect in the code which is triggered in the wake of a ModShelf() action. This patch adds a redirect. To test, edit the details of a private and public list in the OPAC and staff client and confirm that you are redirected to a view of that list's contents after saving. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
QA comment: Is it consistent to redirect to the list's contents and not to the public/private list table ? If this behavior is intended, the proposed patch works as expected. Need additionnal QA.
I have a large patch for 7310 coming for lists which certainly will overlap..
QA comment: I agree with Jonathan that the proposed behaviour is strange, shouldn't we be redirected to /cgi-bin/koha/virtualshelves/shelves.pl?display=privateshelves ? It's a 2 lines patches, so the overlapping with bug 7310 should not be a big deal Marking failed QA, and adding a link to marcel's bug
Created attachment 7923 [details] [review] Bug 4912 [REVISED] After editing private list, user should be redirect to private lists As far as I can tell there isn't a redirect in the code which is triggered in the wake of a ModShelf() action. This patch adds a redirect which is reflects the context of the original "edit" link. To test, edit the details of a list in the OPAC from: - the list of private lists - the list of public lists - the contents view of public or private list After each of these actions you should be redirected back to the page where you clicked the "edit" link.
Created attachment 7932 [details] [review] [SIGNED-OFF] Bug 4912 [REVISED] After editing private list, user should be redirect to private lists As far as I can tell there isn't a redirect in the code which is triggered in the wake of a ModShelf() action. This patch adds a redirect which is reflects the context of the original "edit" link. To test, edit the details of a list in the OPAC from: - the list of private lists - the list of public lists - the contents view of public or private list After each of these actions you should be redirected back to the page where you clicked the "edit" link. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Marking as Passed QA. This new patch takes in consideration previous remarks
I am somewhat confused by this bug. Owen, are the patches from February appropriate for 3.6.x?
This still doesn't work if you choose to edit a list from the toolbar button.
This is still an issue on current master: - Log in to OPAC - Go to 'your Lists' - Click on "edit" near one of the lists - Save Result: The list contents display (you are not taken back to the page where you clicked the "edit" link.).
Created attachment 46329 [details] [review] Bug 4912: Redirect to the appropriate view after editing/deleting a list There are 2 places where a list can be edited/deleted: on the list view and the list content view. After the edition, the user expect to be redirect to the previous page. This patch implements that. Test plan: At the OPAC, delete and edit a list from the 2 differents places. Confirm that you are redirect to the page you come from.
Created attachment 46332 [details] [review] Bug 4912: Redirect to the appropriate view after editing/deleting a list There are 2 places where a list can be edited/deleted: on the list view and the list content view. After the edition, the user expect to be redirect to the previous page. This patch implements that. Test plan: At the OPAC, delete and edit a list from the 2 differents places. Confirm that you are redirect to the page you come from. With patch, redirects work as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 46370 [details] [review] [PASSED QA] Bug 4912: Redirect to the appropriate view after editing/deleting a list There are 2 places where a list can be edited/deleted: on the list view and the list content view. After the edition, the user expect to be redirect to the previous page. This patch implements that. Test plan: At the OPAC, delete and edit a list from the 2 differents places. Confirm that you are redirect to the page you come from. With patch, redirects work as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to Master - Should be in the May 2016 Release. Thanks!
Patch pushed to 3.22.x, will be in 3.22.3