Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload
Summary: neworderempty.tmpl shouldn't call calcNeworderTotal() onload
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) minor
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 11:43 UTC by Dobrica Pavlinusic
Modified: 2012-10-25 23:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
remove onload (1.15 KB, patch)
2010-06-30 11:57 UTC, Dobrica Pavlinusic 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dobrica Pavlinusic 2010-06-30 11:43:17 UTC 
Currently, modifying existing orders will recalculate values if exchange rate has changed, which destroys previous data (our use case is just to modify Planning value fields).

Since fileds also have onChange event which also triggers caclNeworderTotal, onload event seems redundant.
Comment 1 Dobrica Pavlinusic 2010-06-30 11:57:35 UTC 
Created attachment 2288 [details] [review]
remove onload

submited to koha-patches
Comment 2 Marcel de Rooy 2010-12-20 12:09:20 UTC 
Tested. Signed off.
Comment 3 MJ Ray (software.coop) 2011-01-08 11:13:12 UTC 
This bug is mentioned in:
Bug 4920 - neworderempty.tmpl shouldn't call calcNeworderTotal() onload http://lists.koha-community.org/pipermail/koha-patches/2010-December/013431.html
Comment 4 Chris Cormack 2011-01-17 08:14:25 UTC 
Pushed, please test