Bug 4950 - checkbox should be removed when can't place a hold
Summary: checkbox should be removed when can't place a hold
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL: cgi-bin/koha/opac-reserve.pl?biblionu...
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-06 20:37 UTC by Nicole C. Engard
Modified: 2012-10-25 23:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
can't place hold (46.07 KB, image/png)
2010-07-06 20:37 UTC, Nicole C. Engard
Details
Updated interface hides form controls for items which can't be placed on hold (23.47 KB, image/png)
2010-07-09 15:44 UTC, Owen Leonard
Details
Updated interface hides even more controls when no items can be placed on hold (9.07 KB, image/png)
2010-07-09 15:44 UTC, Owen Leonard
Details
Proposed fix (29.02 KB, patch)
2010-07-09 15:54 UTC, Owen Leonard
Details | Diff | Splinter Review
Revised for current HEAD (29.35 KB, patch)
2011-01-05 15:20 UTC, Owen Leonard
Details | Diff | Splinter Review
Proposed fix for 3.2.x (28.90 KB, patch)
2011-01-06 18:49 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2010-07-06 20:37:31 UTC
Created attachment 2315 [details]
can't place hold

When you can't place a hold in the opac, a checkbox still appears to the left of the item making it looks like you should be able to click it and making you overlook the warning saying you can't
Comment 1 Owen Leonard 2010-07-09 15:44:08 UTC
Created attachment 2342 [details]
Updated interface hides form controls for items which can't be placed on hold
Comment 2 Owen Leonard 2010-07-09 15:44:54 UTC
Created attachment 2343 [details]
Updated interface hides even more controls when no items can be placed on hold
Comment 3 Owen Leonard 2010-07-09 15:54:17 UTC Comment hidden (obsolete)
Comment 4 Owen Leonard 2010-12-03 15:45:21 UTC
Original patch will probably not apply cleanly anymore. A revised version of this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-4950-opac-holds-checkbox-2010-07-09
Comment 5 Owen Leonard 2011-01-05 15:20:43 UTC
Created attachment 2947 [details] [review]
Revised for current HEAD
Comment 6 Chris Cormack 2011-01-05 23:52:01 UTC
Pushed please test
Comment 7 Owen Leonard 2011-01-06 18:49:11 UTC
Created attachment 2959 [details] [review]
Proposed fix for 3.2.x
Comment 8 MJ Ray (software.coop) 2011-02-05 19:01:10 UTC
This bug is mentioned in:
Fix for Bug 4950 - checkbox	should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013520.html
Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013532.html
Fix for Bug 4950 - checkbox should be	removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013513.html
Fix for Bug 4950 - checkbox should	be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013541.html