Bug 4954 - modifying a member renew his card
Summary: modifying a member renew his card
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Nahuel Angelinetti
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 08:19 UTC by Nahuel Angelinetti
Modified: 2012-10-25 23:03 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nahuel Angelinetti 2010-07-07 08:19:23 UTC
If you modify a member using another page than step 0 or 3, the expiry date is renewed. It shouldn't.
Comment 1 Owen Leonard 2010-07-07 13:01:48 UTC
Patch for 3.0.x: http://lists.koha-community.org/pipermail/koha-patches/2010-July/012234.html
Comment 2 Owen Leonard 2010-07-07 13:18:39 UTC
Testing on HEAD:

1. Chose patron record with expiration date 2005-05-10.

2. Opened the patron record for editing by clicking a "step 6" link: /cgi-bin/koha/members/memberentry.pl?op=modify&borrowernumber=XX&step=6

3. Edited record, clicked "Save."

4. Patron expiration date has not changed.

Here's the same code section from the file in HEAD:

if ($op eq 'modify' || $op eq 'insert' || $op eq 'save' ){
    if (exists ($newdata{'dateexpiry'}) && !($newdata{'dateexpiry'})){
        my $arg2 = $newdata{'dateenrolled'} || C4::Dates->today('iso');
        $newdata{'dateexpiry'} = GetExpiryDate($newdata{'categorycode'},$arg2);
    }
}
Comment 3 Owen Leonard 2010-07-07 16:11:03 UTC
I'm guessing this is the patch for HEAD?

http://lists.koha-community.org/pipermail/koha-patches/2010-July/012235.html
Comment 4 Galen Charlton 2010-07-07 16:21:29 UTC
Patch pushed.  Please test.  I note, however, that Owen was not able to reproduce the bug.