When adding new patron categories you can save a new category with an existing category code. There is no error message and the new category is not saved. Koha Version: 3.01.00.142
still relevant
Still valid - Paul, this bug is assigned to you?
(In reply to Katrin Fischer from comment #2) > Still valid - Paul, this bug is assigned to you? Yes, but I can't deal with it, sorry. If someone want it, feel free to take it
Could not resolve the issue, but someone may be able to investigate further and add an IF & ELSE statement in the categorie.pl document (/koha/admin) In the categorie.pl document, there is an ADD_VALIDATE section that is called by the ADD_FORM, which the rule should be positioned. The IF & ELSE statement should be that IF a category code that the administrator wants to add already exists, then an error message should arise; ELSE, proceed with the new category code. That should help quite a bit, I gave up... :(
Created attachment 37174 [details] [review] Bug 5002: Display messages on adding/deleting patron category There are no messages on adding and deleting patron category. If an error occurs and the data is not inserted, the interface does not alert the user. This patch adds a message block to alert the user if something wrong happened. Test plan: 1/ Create a patron category PATCAT. You should get a confirmation message. 2/ Try to create another patron category with the same code. You should get an error message 3/ Delete the patron category PATCAT. You should get a confirmation message. Confirm there is no regression on this form (try update an existing patron category too).
Created attachment 37226 [details] [review] [Signed-off] Bug 5002: Display messages on adding/deleting patron category There are no messages on adding and deleting patron category. If an error occurs and the data is not inserted, the interface does not alert the user. This patch adds a message block to alert the user if something wrong happened. Test plan: 1/ Create a patron category PATCAT. You should get a confirmation message. 2/ Try to create another patron category with the same code. You should get an error message 3/ Delete the patron category PATCAT. You should get a confirmation message. Confirm there is no regression on this form (try update an existing patron category too). Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Hi Jonathan, noticed a small problem: - edit an existing patron category - save the change - redirect is to the categories table - but only the edited caegory will show I think it has something to do with a search parameter - visible in the top search. Also some suggestions for the messages: - inserted with success > added successfully - deleteing > deleting - Hm, maybe: The patron category might already exist.
Created attachment 37256 [details] [review] Bug 5002: Show all patron categories after insert + wording changes.
Created attachment 37257 [details] [review] Bug 5002: Show all patron categories after insert + wording changes.
(In reply to Katrin Fischer from comment #7) > Hi Jonathan, > > noticed a small problem: > - edit an existing patron category > - save the change > - redirect is to the categories table - but only the edited caegory will show > > I think it has something to do with a search parameter - visible in the top > search. I thought it was a feature... :) I should have tested on master to confirm. > Also some suggestions for the messages: > - inserted with success > added successfully > - deleteing > deleting > - Hm, maybe: The patron category might already exist. Fixed.
Created attachment 37260 [details] [review] [Signed-off] Bug 5002: Show all patron categories after insert + wording changes. How I tested: - edit an existing patron category - save the change - redirect is to the categories table - it shows all categories OK - wording OK as well Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37319 [details] [review] [PASSED QA] Bug 5002: Display messages on adding/deleting patron category There are no messages on adding and deleting patron category. If an error occurs and the data is not inserted, the interface does not alert the user. This patch adds a message block to alert the user if something wrong happened. Test plan: 1/ Create a patron category PATCAT. You should get a confirmation message. 2/ Try to create another patron category with the same code. You should get an error message 3/ Delete the patron category PATCAT. You should get a confirmation message. Confirm there is no regression on this form (try update an existing patron category too). Followed test plan, works as expected. Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 37320 [details] [review] [PASSED QA] Bug 5002: Show all patron categories after insert + wording changes. How I tested: - edit an existing patron category - save the change - redirect is to the categories table - it shows all categories OK - wording OK as well Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Patches pushed to master. Thanks Jonathan!
Does not apply on 3.18.x, please rebase if you think it is nessecary