Bug 5027 - batch item modification tool modifies unchecked items too
Summary: batch item modification tool modifies unchecked items too
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Srdjan Jankovic
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 14:15 UTC by Ian Walls
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.09 KB, patch)
2010-10-08 01:55 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Walls 2010-07-16 14:15:53 UTC
When using the batch item edit tool, after scanning or uploading the identifiers for the items, one is given the option to uncheck some or all of the items in the list.  Running the update, the tool reports only the checked items being modified, but items that are unchecked are also modified (just not reported on).
Comment 1 Nicole C. Engard 2010-09-07 13:36:44 UTC
Just bumping this report up since it's such a big deal.
Comment 2 Robin Sheat 2010-10-08 01:55:22 UTC
Created attachment 2683 [details] [review]
Proposed patch
Comment 3 Nicole C. Engard 2010-12-16 15:22:52 UTC
Was this patch pushed? I just tested without the patch before applying the patch and it worked A-OK.  Now either I went to test before and never finished the process or this works and is no longer a bug.  Can someone confirm for me?
Comment 4 Julian Maurice 2011-03-11 15:00:43 UTC
I tested without the patch on branches 3.2.x and master, and it works for me too.
The patch was signed off 3 times and pushed on 3.2.x and master (commit 3a4f36b002a5651716efe68242f6711fad936448).
Marked as RESOLVED.