Bug 5028 - Remove references to catmaintain.pl
Summary: Remove references to catmaintain.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-16 15:07 UTC by Owen Leonard
Modified: 2012-10-25 23:10 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed fix (6.59 KB, patch)
2011-08-23 18:59 UTC, Owen Leonard 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2010-07-16 15:07:11 UTC 
A couple of the templates include links to catamaintain.pl: opac-detail.tmpl and detail.tmpl. From detail.tmpl:

<!-- TMPL_IF NAME="type" -->
   <td><a href="/cgi-bin/koha/maint/catmaintain.pl?type=fixitemtype&amp;bi=<!-- TMPL_VAR NAME="biblioitemnumber" -->&amp;item=<!-- TMPL_VAR NAME="itemtype" -->">Fix Itemtype</a></td>
<!-- /TMPL_IF -->

I'm assuming "type" never evaluates as true, because as far as I can tell this link never shows up. If it did it would point to a nonexistent file. There is no maint/catmaintain.pl.

Is it safe to remove catmaintain.tmpl and the links to catmaintain.pl?
Comment 1 Owen Leonard 2011-08-23 18:59:49 UTC 
Created attachment 5109 [details] [review]
Proposed fix

catmaintain.pl doesn't exist anymore. References to it in the templates should be removed.
Comment 2 Ian Walls 2011-09-02 11:49:34 UTC 
maint/catmaintain.pl no longer exists (deleted Sept 6 2006, commit ID 7e52a5665), so there is no need to reference it anymore.  Template only change, easy to read, marking as Passed QA.

Please check koha-tmpl/intranet-tmpl/prog/en/includes/error-top.inc for an additional reference to this deleted file.
Comment 3 Owen Leonard 2011-09-02 13:30:49 UTC 
I'm hoping error-top.inc will go away with the approval of Bug 6768.
Comment 4 Ian Walls 2011-09-02 13:52:36 UTC 
Bug 6768 has been passed, so the remaining reference to catmaintain.pl will be removed with it's committal.
Comment 5 Chris Cormack 2011-09-03 08:48:35 UTC 
Pushed, please test
Comment 6 Chris Nighswonger 2011-10-26 18:02:36 UTC 
The fix for this bug was published in the 3.4.5 release. If you were the reporter of this bug, please take time to verify the fix and update the status of this bug report accordingly. If the bug is fixed to your satisfaction, please close this report.