Bug 5059 - Inconsistent use of ordering price and list price in vendor form
Summary: Inconsistent use of ordering price and list price in vendor form
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: rel_3_2
Hardware: All All
: PATCH-Sent (DO NOT USE) trivial (vote)
Assignee: Katrin Fischer
QA Contact: Bugs List
URL: /cgi-bin/koha/acqui/supplier.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-26 10:55 UTC by Katrin Fischer
Modified: 2010-11-23 10:32 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot of new vendor form (15.14 KB, image/png)
2010-07-26 10:55 UTC, Katrin Fischer
Details
screenshot after changes (18.46 KB, image/png)
2010-07-26 11:14 UTC, Katrin Fischer
Details
proposed patch (3.91 KB, patch)
2010-07-26 11:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2010-07-26 10:55:51 UTC
Created attachment 2420 [details]
screenshot of new vendor form

The vendor form uses the terms list price for currency and ordering price for tax information.

After discussion in IRC we came to the conclusion that both terms have the same meaning.

07-26-2010
(12:16:19) chris: i think in the context of the vendor form its the same
(12:16:25) chris: thats how the code uses it anyway
(12:17:09) chris: it will use the currency chosen to convert the price, then if there is tax then subtract that, then remove the discount
(12:18:29) chris: to end up with the estimated cost, so the currency of list price and tax of ordering price are both used for the same thing
Comment 1 Katrin Fischer 2010-07-26 11:14:14 UTC
Created attachment 2421 [details]
screenshot after changes
Comment 2 Katrin Fischer 2010-07-26 11:48:01 UTC
Created attachment 2422 [details] [review]
proposed patch

Changes Ordering price to List price and makes spelling more consistent.
Comment 3 Katrin Fischer 2010-11-12 20:31:05 UTC
Rebased to HEAD without any conflicts.
Comment 4 Chris Cormack 2010-11-12 22:36:03 UTC
Patch pushed test and close
Comment 5 Katrin Fischer 2010-11-14 12:19:20 UTC
Tested with HEAD.
Comment 6 Chris Nighswonger 2010-11-18 03:15:13 UTC
This bug has a patch presently committed to HEAD and 3.2.x.

Please take the appropriate action to update the status of this bug.

Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter.
Comment 7 Katrin Fischer 2010-11-23 10:32:10 UTC
Successfully tested with 3.2.1