Import script shouldn't remove an information present in entering biblio records.
Should it be a switchable option? There are good reasons for removing the (often erroneous) hyphens. And standard usage in marc is without the hyphens. (NB you can generate hyphens from a un-hyphenated number using the perl module Business::ISBN)
> Should it be a switchable option? There are good reasons for removing the > (often erroneous) hyphens. And standard usage in marc is without the hyphens. Yes, but when you have hand crafted a biblio record file with ISBN containing hyphens you prefer not to loose them. That's interesting: MARC21 records seems to have no hyphens, you're correct, but UNIMARC records have generally hyphens in ISBN field (BNF and SUDOC) and there is EAN field for ISBN without -... We can conclude that for MARC21 entering bibli records we don't have to remove hyphens since they shouldn't have any. And for UNIMARC records, we mustn't remove them since they are expected by the standard. > (NB you can generate hyphens from a un-hyphenated number using the perl module > Business::ISBN) I already appreciate and use this very useful module. Thanks Colin for the tip.
What's the current state of this patch?
> What's the current state of this patch? Here it is: http://lists.koha-community.org/pipermail/koha-patches/2010-December/013262.html
In my opinion, removing dashes from ISBN must be an option. Anyway, ISBN is a repeatable field. Currently, bulkmarcimport.pl removes dashes only from the first occurrence.
Created attachment 3892 [details] [review] Proposed patch
> In my opinion, removing dashes from ISBN must be an option. This is the case in my proposed patch. You just have to sign it. > Anyway, ISBN is a repeatable field. Currently, bulkmarcimport.pl > removes dashes only from the first occurrence. And still the case in my patch. But it isn't a big deal to fix it.
This was submitted well before the feature freeze, (December in fact) so I have pushed it, please test